Release recnet-web v1.15.0 / recnet-api v1.7.1 #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
## Description <!--- Describe your changes in detail --> Mark verified article. ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> - #268 ## Notes <!-- Other thing to say --> ## Test <!--- Please describe in detail how you tested your changes locally. --> Should see "verified" in rec card (Need to change some articles' `isVerified` to true in order to test) ## Screenshots (if appropriate): <!--- Add screenshots of your changes here -->  ## TODO - [x] Clear `console.log` or `console.error` for debug usage - [x] Update the documentation `recnet-docs` if needed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
## Description Add rec reaction to rec related API. Design Doc: [Notion](https://www.notion.so/Rec-Emoji-Reaction-ad4c0db048574a6183a672b25d209e5c) - GET /recs/rec/{id} - GET /recs - GET /recs/feed The Rec schema in response API becomes: ``` { "id": "string", "description": "string", ... "reaction": { "selfReactions": ["string"], // list emun of reaction that user clicked "numReactions": [ { "type": "string", // enum of reaction "count": "number" // total count of the reaction } ] } } ``` ## Related Issue - #60 ## Notes <!-- Other thing to say --> As `GET /recs/rec/{id}` and `GET /recs/` do not require an Auth user to login, I added a decorator of `@AuthOptional` to get the user information from jwt token. ## Test 1. Hit `POST /recs/{id}/reactions` and `DELETE /recs/{id}/reactions` to create and delete rec for a specific Recommendation. 2. Use the API above to query recs and validate if the `reactions` field is returned correctly. 3. Try to create rec reactions with different users to test if selfReactions and numReactions work correctly. ## Screenshots (if appropriate): <!--- Add screenshots of your changes here --> ## TODO - [x] Clear `console.log` or `console.error` for debug usage - [ ] Update the documentation `recnet-docs` if needed
## Description <!--- Describe your changes in detail --> Cache the output of `nx build recnet-release-action` using the hash of source code in `libs/recnet-release-action/src` to accelerate gh action ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> ## Notes <!-- Other thing to say --> Successful run 1 (cache miss): https://github.com/lil-lab/recnet/actions/runs/11335345342/attempts/1 Successful run 2 (cache hit): https://github.com/lil-lab/recnet/actions/runs/11335345342 ## Test <!--- Please describe in detail how you tested your changes locally. --> ## Screenshots (if appropriate): <!--- Add screenshots of your changes here --> You can see in the first run, cache doesn't hit, and the action start downloading node packages and compiling the typescript files.  And it saves the output in cache in the end of first successful run.  In the second run, you can see it did hit the cache and skip the downloading and compiiing steps  ## TODO - [x] Clear `console.log` or `console.error` for debug usage - [x] Update the documentation `recnet-docs` if needed
## Description <!--- Describe your changes in detail --> Add reactions buttons under rec page ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> - #60 ## Notes <!-- Other thing to say --> ## Test <!--- Please describe in detail how you tested your changes locally. --> Find a rec and go to rec page `rec/:id` - When not logged in, should be able to view reactions. But when clicking emojis, should see an error toast shows up. - When logged in, should be able to select reaction. And after selection, should see the reaction chip, which displays how many users have clicked that reaction, displays the number correctly. - When click again (no matter using the reaction popover or click on reaction chip), should remove that reaction (reaction count decrement by 1) ## Screenshots (if appropriate): <!--- Add screenshots of your changes here -->  Reaction popover:  Reaction chip:  ## TODO - [x] Clear `console.log` or `console.error` for debug usage - [x] Update the documentation `recnet-docs` if needed
swh00tw
approved these changes
Oct 16, 2024
joannechen1223
approved these changes
Oct 17, 2024
swh00tw
changed the title
swh00tw
changed the title
swh00tw
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RecNet auto-release action
This is an auto-generated PR by recnet-release-action 🤖
Please make sure to test your changes in staging before merging.
Related Issues
Related PRs
Staging links
recnet-web: https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app
recnet-api: https://dev-api.recnet.io/api