Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[recnet-web] Rec reactions UI #331

Merged
merged 4 commits into from
Oct 16, 2024
Merged

[recnet-web] Rec reactions UI #331

merged 4 commits into from
Oct 16, 2024

Conversation

swh00tw
Copy link
Collaborator

@swh00tw swh00tw commented Oct 15, 2024 •
edited
Loading

Description

Add reactions buttons under rec page

Related Issue

Notes

Test

Find a rec and go to rec page rec/:id

  • When not logged in, should be able to view reactions. But when clicking emojis, should see an error toast shows up.
  • When logged in, should be able to select reaction. And after selection, should see the reaction chip, which displays how many users have clicked that reaction, displays the number correctly.
  • When click again (no matter using the reaction popover or click on reaction chip), should remove that reaction (reaction count decrement by 1)

Screenshots (if appropriate):

Screenshot 2024-10-15 at 12 42 48 AM

Reaction popover:
Screenshot 2024-10-15 at 12 46 35 AM

Reaction chip:
Screenshot 2024-10-15 at 12 46 49 AM

TODO

  • Clear console.log or console.error for debug usage
  • Update the documentation recnet-docs if needed

@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
recnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 9:11pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
recnet-docs ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 9:11pm

joannechen1223
joannechen1223 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@joannechen1223 joannechen1223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swh00tw swh00tw merged commit 9e27c4a into dev Oct 16, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Merged
swh00tw added a commit that referenced this pull request Oct 17, 2024
@swh00tw
Release recnet-web v1.15.0 / recnet-api v1.7.1 (#329)
579ade6 
## RecNet auto-release action
This is an auto-generated PR by recnet-release-action 🤖
Please make sure to test your changes in staging before merging. 
## Related Issues
- #60
- #268
## Related PRs
- #331
- #330
- #328
- #326
## Staging links
recnet-web:
[https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app](https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app)
recnet-api:
[https://dev-api.recnet.io/api](https://dev-api.recnet.io/api)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joannechen1223 joannechen1223 joannechen1223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swh00tw @joannechen1223