Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[recnet-web] Subscription setting UI #350

Merged
merged 15 commits into from
Nov 8, 2024
Merged

Conversation

swh00tw
Copy link
Collaborator

@swh00tw swh00tw commented Nov 7, 2024

Description

Finish subscription setting UI to select subscription type and channels.

Misc:

  • Refactor code (split code) for UserSettingDialog
  • Add setting button in User Dropdown
Screenshot 2024-11-07 at 6 19 58 PM

Related Issue

Notes

Test

Open Setting Dialog and play with the subscription form

  • For weekly digest, should show error if trying to unsubscribe all channels
  • After save, verify changes in DB using prisma:studio or sql client

Screenshots (if appropriate):

Screenshot 2024-11-07 at 6 22 20 PM

TODO

  • Clear console.log or console.error for debug usage
  • Update the documentation recnet-docs if needed

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
recnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 3:23am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
recnet-docs ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 3:23am

Copy link
Collaborator

@joannechen1223 joannechen1223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swh00tw swh00tw merged commit 07e3e11 into dev Nov 8, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
swh00tw added a commit that referenced this pull request Nov 8, 2024
## RecNet auto-release action
This is an auto-generated PR by recnet-release-action 🤖
Please make sure to test your changes in staging before merging. 
## Related Issues
- #260
- #261
## Related PRs
- #350
- #351
- #349
## Staging links
recnet-web:
[https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app](https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app)
recnet-api:
[https://dev-api.recnet.io/api](https://dev-api.recnet.io/api)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants