Release dev to master #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…k digest (#349) ## Description - Migrate email digest to new subscription architecture and add slack weekly digest. - Refactor the email module and add the Slack module. - Delete testing email/slack API ## Related Issue - #261 - #260 ## Notes <!-- Other thing to say --> ## Test <!--- Please describe in detail how you tested your changes locally. --> 1. Insert some subscription data in your local DB. For example: ``` INSERT INTO "Subscription" ("userId", "type", "channel") VALUES ('{your user id}, 'WEEKLY_DIGEST', 'SLACK'); ``` 2. Change the **WEEKLY_DIGEST_CRON** constant in `recnet-api/modules/subscription/subscription.const.ts` to the time that close to your current timestamp. ``` export const WEEKLY_DIGEST_CRON = "0 {min} {hour} * * *"; ``` 3. Start the server locally ``` nx serve recnet-api ``` ## Screenshots (if appropriate): <!--- Add screenshots of your changes here --> <img width="1462" alt="Screenshot 2024-11-07 at 3 02 26 PM" src="https://github.com/user-attachments/assets/f01540df-1ef9-4e43-bd05-82e922ac12a2"> ## TODO - [x] Clear `console.log` or `console.error` for debug usage - [ ] Update the documentation `recnet-docs` if needed - [ ] Migrate current email subscription for all users - [ ] Update Slack token on AWS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
## Description Add user subscriptions api - `GET /users/subscriptions` - `POST /users/subscriptions` ## Related Issue - #260 ## Notes Design doc: https://www.notion.so/Multiple-Distributing-Channels-Slack-Integration-61323d4345c547cb869129e117c5d722 ## Test <!--- Please describe in detail how you tested your changes locally. --> 1. Run server locally 2. Hit the two new apis with your Auth token ## Screenshots (if appropriate): <img width="889" alt="Screenshot 2024-11-07 at 9 26 07 PM" src="https://github.com/user-attachments/assets/d48b5fe6-aa86-4475-8958-954201ad203d"> <img width="877" alt="Screenshot 2024-11-07 at 9 25 39 PM" src="https://github.com/user-attachments/assets/4205bd9a-a19e-486e-8453-1fbbd879f6ce"> ## TODO - [x] Clear `console.log` or `console.error` for debug usage - [ ] Update the documentation `recnet-docs` if needed
## Description
<!--- Describe your changes in detail -->
Finish subscription setting UI to select subscription type and channels.
Misc:
- Refactor code (split code) for UserSettingDialog
- Add setting button in User Dropdown
<img width="363" alt="Screenshot 2024-11-07 at 6 19 58 PM"
src="https://github.com/user-attachments/assets/376b45de-9eff-4f23-9e32-d4532f9c62d9">
## Related Issue
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->
## Notes
<!-- Other thing to say -->
## Test
<!--- Please describe in detail how you tested your changes locally. -->
Open Setting Dialog and play with the subscription form
- For weekly digest, should show error if trying to unsubscribe all
channels
- After save, verify changes in DB using `prisma:studio` or sql client
## Screenshots (if appropriate):
<!--- Add screenshots of your changes here -->
<img width="652" alt="Screenshot 2024-11-07 at 6 22 20 PM"
src="https://github.com/user-attachments/assets/28628173-f325-4dae-b341-65d3c182e201">
## TODO
- [x] Clear `console.log` or `console.error` for debug usage
- [x] Update the documentation `recnet-docs` if needed
swh00tw
approved these changes
Nov 8, 2024
swh00tw
added a commit
that referenced
this pull request
Nov 8, 2024
## Description <!--- Describe your changes in detail --> Fix bug when login after #352  ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> ## Notes <!-- Other thing to say --> ## Test <!--- Please describe in detail how you tested your changes locally. --> https://recnet-git-fix-login-bug-recnet-542617e7.vercel.app/ This is the preview site for this branch (with the fix). Should be able to login without seeing any error. ## Screenshots (if appropriate): <!--- Add screenshots of your changes here --> ## TODO - [ ] Clear `console.log` or `console.error` for debug usage - [ ] Update the documentation `recnet-docs` if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RecNet auto-release action
This is an auto-generated PR by recnet-release-action 🤖
Please make sure to test your changes in staging before merging.
Related Issues
Related PRs
Staging links
recnet-web: https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app
recnet-api: https://dev-api.recnet.io/api