Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grpc api related to the block #291

Merged
merged 7 commits into from
Jul 20, 2021

Conversation

brew0722
Copy link
Contributor

@brew0722 brew0722 commented Jul 16, 2021

Description

  • Add below API to integrate with grpc.
    BlockByHash, BlockResultsByHeight

  • Add prove parameter to GetTxsEvent API.
    In the existing case, prove is hard-coded to true, which shows slow performance.

  • Migrate swagger-gen.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@brew0722 brew0722 added this to the CBDC functional requirements milestone Jul 16, 2021
@brew0722 brew0722 self-assigned this Jul 16, 2021
@CLAassistant
Copy link

CLAassistant commented Jul 16, 2021

CLA assistant check
All committers have signed the CLA.

@brew0722 brew0722 marked this pull request as draft July 16, 2021 02:15
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@7ecb96e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage        ?   52.85%           
=======================================
  Files           ?      639           
  Lines           ?    47548           
  Branches        ?        0           
=======================================
  Hits            ?    25132           
  Misses          ?    19518           
  Partials        ?     2898           

@brew0722 brew0722 marked this pull request as ready for review July 16, 2021 02:49
@brew0722 brew0722 changed the title refactor: add grpc api related to the block feat: add grpc api related to the block Jul 16, 2021
Copy link

@egonspace egonspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace
Copy link

CHANGELOG also needs to be updated.

@zemyblue
Copy link
Member

zemyblue commented Jul 20, 2021

@brew0722 Could you change the location of wasm's protobuf files?

@brew0722
Copy link
Contributor Author

brew0722 commented Jul 20, 2021

@zemyblue
The legacy wasm proto paths will be resolved in cosmwasm/wasmd 0.17.0 migration PR.
https://github.com/CosmWasm/wasmd/tree/v0.17.0/proto/cosmwasm/wasm/v1beta1
#249 (As a result of rechecking, that was missing in PR#249. Thank you.)

@slave5vw Could you change the location of wasm's protobuf files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants