-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add grpc api related to the block #291
Conversation
Existing hardcoded prove true has a performance degradation issue. So needs to be disabled as needed.
Codecov Report
@@ Coverage Diff @@
## main #291 +/- ##
=======================================
Coverage ? 52.85%
=======================================
Files ? 639
Lines ? 47548
Branches ? 0
=======================================
Hits ? 25132
Misses ? 19518
Partials ? 2898 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@brew0722 Could you change the location of wasm's protobuf files? |
@zemyblue
|
Description
Add below API to integrate with grpc.
BlockByHash
,BlockResultsByHeight
Add prove parameter to
GetTxsEvent
API.In the existing case, prove is hard-coded to
true
, which shows slow performance.Migrate swagger-gen.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes