Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm): merge wasmd 0.17.0 #249

Merged
merged 79 commits into from
Jul 20, 2021
Merged

Conversation

shiki-tak
Copy link
Contributor

@shiki-tak shiki-tak commented Jun 17, 2021

Description

closes: #263


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

alpe and others added 30 commits March 11, 2021 09:09
Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.4.3 to 1.5.1.
- [Release notes](https://github.com/golang/protobuf/releases)
- [Commits](golang/protobuf@v1.4.3...v1.5.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Refactor wasm message handlers

* Add handler plugin tests

* Review feedback

* Add handler and query tests
Handle non default transfer port id
* Move internal subfolders up

* Fix broken imports and fmt
Remove deprecated build targets
* Restructure protobuf dir and generation

* Format protobuf definitions
* Fix contact address in code of conduct

* Update CODE_OF_CONDUCT.md

Co-authored-by: Orkun Külçe <orkunkl@users.noreply.github.com>

Co-authored-by: Orkun Külçe <orkunkl@users.noreply.github.com>
Upgrade cosmos-sdk to v0.42.2
Bumps [github.com/rs/zerolog](https://github.com/rs/zerolog) from 1.20.0 to 1.21.0.
- [Release notes](https://github.com/rs/zerolog/releases)
- [Commits](rs/zerolog@v1.20.0...v1.21.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…m/golang/protobuf-1.5.1

Bump github.com/golang/protobuf from 1.4.3 to 1.5.1
…m/rs/zerolog-1.21.0

Bump github.com/rs/zerolog from 1.20.0 to 1.21.0
…m/cosmos/cosmos-sdk-0.42.3

Bump github.com/cosmos/cosmos-sdk from 0.42.2 to 0.42.3
Introduce new interfaces for extendability
@shiki-tak shiki-tak changed the title [WIP] feat(wasm): merge wasmd 0.17.0 feat(wasm): merge wasmd 0.17.0 Jul 1, 2021
@shiki-tak
Copy link
Contributor Author

When the following PRs are merged and the latest version is released, the test will path. (I have already confirmed that the test will path locally.)
Finschia/wasmvm#36

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 5 committers have signed the CLA.

✅ loloicci
✅ shiki-tak
❌ alpe
❌ ethanfrey
❌ dependabot-preview[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

x/wasm/keeper/keeper.go Outdated Show resolved Hide resolved
@@ -0,0 +1,110 @@
# Governance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be rewritten. so I think it would be better to remove it for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, removed it.

x/wasm/IBC.md Outdated
@@ -0,0 +1,137 @@
# IBC specification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file also should be rewritten. so I think it would be better to remove it for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, removed it.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@e6047cb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage        ?   53.01%           
=======================================
  Files           ?      642           
  Lines           ?    47749           
  Branches        ?        0           
=======================================
  Hits            ?    25314           
  Misses          ?    19520           
  Partials        ?     2915           

@shiki-tak shiki-tak force-pushed the shiki_tak/feat/merge-wasmd-0.17.0 branch 2 times, most recently from 7c90af6 to f00b2a2 Compare July 19, 2021 03:29
Copy link
Contributor

@brew0722 brew0722 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/CosmWasm/wasmd/tree/v0.17.0/proto/cosmwasm/wasm/v1beta1
changed proto file paths are not included this pr.(moved x/wasm/types/*.proto -> proto/cosmwasm/wasm/v1beta1)

@shiki-tak shiki-tak force-pushed the shiki_tak/feat/merge-wasmd-0.17.0 branch from 0da9ef5 to 577c2c0 Compare July 20, 2021 07:32
@whylee259 whylee259 merged commit 53f2410 into main Jul 20, 2021
@whylee259 whylee259 deleted the shiki_tak/feat/merge-wasmd-0.17.0 branch July 20, 2021 07:53
brew0722 pushed a commit to brew0722/lbm-sdk that referenced this pull request Jul 20, 2021
wasmd 0.17.0(Finschia#249) After merging, the legacy style wasm proto path was fixed.
brew0722 added a commit that referenced this pull request Jul 20, 2021
wasmd 0.17.0(#249) After merging, the legacy style wasm proto path was fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge wasmd 0.17.0
7 participants