Skip to content

Add sender properties #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2020
Merged

Add sender properties #247

merged 3 commits into from
Mar 26, 2020

Conversation

@morugu
Copy link
Contributor

@morugu morugu commented Mar 18, 2020 •
edited by okue
Loading

closes #248

  • add sender properties.
  • add test send message with sender

API Docs: https://developers.line.biz/en/reference/messaging-api/#icon-nickname-switch

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@okue
Copy link
Member

okue commented Mar 26, 2020

Sorry, for the late review.

okue
okue approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@okue okue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.
Thanks!

@okue okue merged commit 06e0eae into line:master Mar 26, 2020
@okue okue added this to the 1.17.0 milestone Jun 26, 2020
@rotoyang rotoyang mentioned this pull request Apr 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@okue okue okue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

Support icon-nickname-switch

3 participants

@morugu @CLAassistant @okue