[IMPROVEMENT] Tracking for failed alerts #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
- Coverage 47.8% 47.24% -0.57%
==========================================
Files 45 46 +1
Lines 2510 2542 +32
==========================================
+ Hits 1200 1201 +1
- Misses 1310 1341 +31
Continue to review full report at Codecov.
|
Even though Promgen is instrumented with Sentry, users need a way to know if their alerts are being sent properly. While a more robust retry mechanism will be attempted in the future this should give more visibility into the current state - Add `error_count` and `sent_count` to Alert model for tracking - Add `AlertError` log for tracking failed messages - Refactor `tasks.send_alert` to better log errors and increment counters Future work to make sender.test more aware to avoid special casing the alert_pk check in `tasks.send_alert`
kfdm
force-pushed
the
alert-error-tracking
branch
from
168d809
to
efe8dd8
Compare
shokada
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though Promgen is instrumented with Sentry, users need a way to know if their alerts are being sent properly. While a more robust retry mechanism will be attempted in the future this should give more visibility into the current state
error_countandsent_countto Alert model for trackingAlertErrorlog for tracking failed messagestasks.send_alertto better log errors and increment countersFuture work to make sender.test more aware to avoid special casing the alert_pk check in
tasks.send_alert