Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Tracking for failed alerts #200

Merged
merged 1 commit into from
Dec 2, 2019

Commits on Nov 29, 2019

  1. [IMPROVEMENT] Tracking for failed alerts

    Even though Promgen is instrumented with Sentry, users need a way to
    know if their alerts are being sent properly. While a more robust retry
    mechanism will be attempted in the future this should give more
    visibility into the current state
    
    - Add `error_count` and `sent_count` to Alert model for tracking
    - Add `AlertError` log for tracking failed messages
    - Refactor `tasks.send_alert` to better log errors and increment counters
    
    Future work to make sender.test more aware to avoid special casing the
    alert_pk check in `tasks.send_alert`
    kfdm committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    efe8dd8 View commit details
    Browse the repository at this point in the history