Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixed and uppercase idents #105

Closed
waywardmonkeys opened this issue Dec 21, 2024 · 0 comments · Fixed by #109
Closed

Mixed and uppercase idents #105

waywardmonkeys opened this issue Dec 21, 2024 · 0 comments · Fixed by #109
Labels
bug Something isn't working

Comments

@waywardmonkeys
Copy link
Collaborator

The code in color currently only handles lowercase idents while the spec says it should be case insensitive.

This also impacts use from svgtypes which currently tests that mixed cases work.

svgtypes expects that these parse:

  • "RGB(254, 203, 231)"
  • "RgB(254, 203, 231)"
  • RED
  • ReD
@waywardmonkeys waywardmonkeys added the bug Something isn't working label Dec 21, 2024
raphlinus added a commit that referenced this issue Dec 21, 2024
@raphlinus
Make color parsing case insensitive
8e81c8d 
The spec requires matching both lowercase and uppercase. The general
solution is to copy the identifier into a temporary stack allocated
buffer and do the case conversion there, before matching.

Fixes #105
@raphlinus raphlinus mentioned this issue Dec 21, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 21, 2024
@raphlinus
Make color parsing case insensitive (#109)
4f3b196 
The spec requires matching both lowercase and uppercase. The general
solution is to copy the identifier into a temporary stack allocated
buffer and do the case conversion there, before matching.

Fixes #105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make color parsing case insensitive linebender/color
1 participant
@waywardmonkeys