Make color parsing case insensitive #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec requires matching both lowercase and uppercase. The general solution is to copy the identifier into a temporary stack allocated buffer and do the case conversion there, before matching. Fixes #105
waywardmonkeys
approved these changes
Dec 21, 2024
tomcur
approved these changes
Dec 21, 2024
waywardmonkeys
approved these changes
Dec 21, 2024
tomcur
added a commit
to tomcur/color
that referenced
this pull request
Dec 21, 2024
These pass since linebender#109.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 21, 2024
These pass since #109.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec requires matching both lowercase and uppercase. The general solution is to copy the identifier into a temporary stack allocated buffer and do the case conversion there, before matching.
Fixes #105