DRAFT: Experiment/fc data grid virtualized #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on offset is not in overflow size calc
ling1726
pushed a commit
that referenced
this pull request
Mar 1, 2023
…rosoft#23334) * Add accessibility scenarios for the Accordion, Button and Popover components * Change scenario titles * Use string directly as component prop value Co-authored-by: Peter Varholak <peter.varholak@gmail.com> * replace alert with status text and fix warnings * Replace useCallback with ordinary function * Revert the title for the scenarios list page * Removed unnecessary fragment * Use <Label> components * Remove not used exports * Change files * Replace Calendar buttons scenario with Messenger buttons scenario, add Tooltip scenario and correct some wording * Add ToggleButton component scenario and replace button element with Button component in Tooltip scenario * Replace calendar scenario link with messenger scenario link and grammar changes * Add Link component scenario, and small changes in Accordion * Add beta version of SplitButton scenario * Make SplitButton scenario working * Change label for menu button within SplitButton * Replace Button with MenuButton in Menu scenario * Fix error in Menu scenario * Refactor aria-label for menu button within split button * Extract Postpone menu item into separate button * Add tooltip button without triggerAriaAttribute prop * Add other gender radio option * Rename disabled links and add nav region * Add heading and description for toggle buttons * Add FAQ accordion scenario and change radios in personal form accordion scenario * Add h1 for accordion scenarios * Fix lint errors and change Tooltip scenario for more real life examples * Add icon buttons for Tooltip scenario * Add x of Y and Submit button to simple form accordion scenario * Add menu with split item scenario * Change menu items in menu with split item scenario * Fix visible label in split button in menu secondary action * Remove X of Y in Accordion scenario * Enable dismiss of tooltip with Escape * Move password hint button between password label and input field * Reintroduce X of Y for personal form accordion scenario * Add as='h2' for accordion headers * Remove X of Y in personal form accordion scenario * Fix Tooltip error regarding relationship attribute * Add uncomplete Input scenario * Add slider component scenario and fix TS error in Input scenario * Change files * Fix import errors * Add screen reader supported validation to input scenario form * Add lint disable next line for complex object * Rename labels in slider scenario * Remove errorneously inserted unused declaration and import * Replace <input> with <Input> and add <form> * Remove already not needed import error ignore comments * Add onBlur validation for Input scenario and changed input requirements and hints * Replace 'any' with new type * Fix error messages flickering * Add aria=invalid in Input scenario * Fix nickname typo * Replace h1 heading with h2 * Implement form validation using React Hook Form * Ignore line max length lint error and add react-hook-form dependency * Focus error element upon form submission and narrate when already focused * Change form revalidate to onBlur * Replace custom validation with React Hook Form library, but narration is not working properly * toggle alert role to force re-reading of errors * fix narration on submit * Fix onblur error narration instead of first error narration on submit * Remove pubsub dependancy which was moved to root * Remove the password hint scenario for Tooltip component * fix lint issues * fix package * fix * cleanup * Replace native checkbox with Checkbox Fluent UI component * Fix typo in word 'reminder' * Add basic Checkbox scenario and consistency fixes in other scenarios * Add other accessibility relevant variants of Checkbox * Add temporary version of RadioGroup scenario and replace native HTML elements with Fluent UI components in some other scenarios * Replace native HTML checkbox elements with Fluent UI components * Replace native HTML input with Fluent UI Input component * Add disabled items variant for RadioGroup and some nit picking fixes in other scenarios * Add disabled RadioGroup variant * Replace tabindex values from 0 to -1 * Add Spinner, Switch and TabList components scenarios * Add disabled tab for TabList scenario * Add Notifications tab for TabList scenario * Add Textarea scenarioand changes to TabList scenario * Make checkboxes appear on a new line * Make textareas appear on a new line * Add vertical and overflow variants of TabList scenarios and small refactoring * Fix broken page with scenarios * Add Input with placeholder attribute * Add disabled Input example and preparation for readonly Input * Add lint ignore for long regex lines * Make <input> readonly and small refactoring of security code generating function * Proper setting of readOnly prpprop on Input component scenario * Add validation for Textarea scenario, add more variants and fix Input validation behavior * include accessibility scenario stories in the public docs * fix imports * fix imports * chore: add index.stories.tsx * Add FAQ accordion story * Add first half of v9 accessibility scenarios * Add remaining v9 accessibility scenarios * Make Send button not disabledFocusable * Make error message alerting more robust and remove 500ms setTimeout for first error field focus * Make overflow button in TabList not selected * Fix email validating birthDay instead * Fix email validation and some code cleaning * Fix first error field focus upon form submission problem * Make Input and Textarea scenarios more like a real example * Fix email validation when not required * Fix Input and Textarea scenario form validation and text changes * Fix invalid disabled textarea bug * fix scenarios link, remove them from sidebar again * Update apps/public-docsite-v9/.storybook/main.utils.js Co-authored-by: Micah Godbolt <micahgodbolt@gmail.com> * fix md file change * temporarily add `as` to MenuItem usage Co-authored-by: Peter Varholak <peter.varholak@gmail.com> Co-authored-by: Juraj Kapsiar <jukapsia@microsoft.com> Co-authored-by: Adam Samec <asamec@microsoft.com> Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com> Co-authored-by: Juraj Kapsiar <jurokapsiar@gmail.com> Co-authored-by: Micah Godbolt <micahgodbolt@gmail.com>
ling1726
pushed a commit
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo Experiment to sync on virtualizer functionality.