[controller] Fail hybrid store conversion if a pushjob is running #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangminchn
requested changes
Aug 28, 2024
...s/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceParentHelixAdmin.java
Show resolved
Hide resolved
...st/java/com/linkedin/venice/controller/TestClusterLevelConfigForActiveActiveReplication.java
Show resolved
Hide resolved
majisourav99
force-pushed
the
targetColoFix
branch
from
ef1e963 to
a3eff89
Compare
huangminchn
reviewed
Aug 30, 2024
...tionTest/java/com/linkedin/venice/controller/TestClusterLevelConfigForNativeReplication.java
Show resolved
Hide resolved
huangminchn
approved these changes
Sep 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail hybrid store conversion if a pushjob is already running
If a batch store is converted to hybrid while a push is already running, it might convert the store to hybrid when its running the push in the target colo. After the target colo push finishes, the state of the store is mismatched in target vs child colo. Then during the push to other colo which does not support hybrid store ingestion and might not have the RT topic created which would make the pushjob hang forever. This PR blocks conversion to hybrid store during actively running pushes.
How was this PR tested?
CI
Does this PR introduce any user-facing changes?