Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up stats and dashboards for StatefulSets #1983

Closed
robertrbruno opened this issue Dec 13, 2018 · 5 comments
Closed

Wire up stats and dashboards for StatefulSets #1983

robertrbruno opened this issue Dec 13, 2018 · 5 comments

Comments

@robertrbruno
Copy link

I saw in the issue for adding injection of StatefulSets mention of Grafana support, but didn't see an issue for it yet. Sorry if this is a repeat.

@klingerf
Copy link
Contributor

@robertrbruno Thanks for opening this! When wiring up stats originally we only got through a subset of Kubernetes workloads for which we can provide stats -- see #627 for more details about that. Unfortunately we never made it to statefulsets, but we can use this issue to track adding CLI / Web UI / Grafana support for them.

@klingerf klingerf changed the title Add Grafana dashboard for statefulsets Wire up stats and dashboards for StatefulSets Dec 19, 2018
@grampelberg grampelberg added the priority/P2 Nice-to-have for Release label Jan 23, 2019
@dadjeibaah dadjeibaah removed their assignment Feb 1, 2019
@klingerf
Copy link
Contributor

klingerf commented Feb 2, 2019

Just wanted to add a bit more context here. Setting up stat support for StatefulSets will be very similar to PR #2086, which added stat support for DaemonSets.

The statefulset label already exists in our Prometheus metrics, so this should not require any proxy changes. We'll need a new Grafana dashboard that displays these stats. We'll also want to update the linkerd stat, linkerd tap, and linkerd top commands to support the resource, which will require some changes to the public-api and tap servers, and we'll want to start displaying StatefulSet data in the web UI.

@ihcsim ihcsim self-assigned this Feb 5, 2019
ihcsim pushed a commit that referenced this issue Feb 6, 2019
Fixes #1983

Signed-off-by: Ivan Sim <ivan@buoyant.io>
ihcsim pushed a commit that referenced this issue Feb 6, 2019
Fixes #1983

Signed-off-by: Ivan Sim <ivan@buoyant.io>
@ihcsim
Copy link
Contributor

ihcsim commented Feb 7, 2019

@grampelberg It looks like at the moment, we aren't capturing any metrics for non-http stateful applications. The dashboard, CLI and grafana all show zero metrics. The pods don't even show up in grafana, as seen in the screenshots below. @klingerf mentioned that this happens because when the protocol detection failed, the proxy won't call proxy-api and hence, it receives no metadata including the pod name.

image

image

@klingerf and I discussed about whether it is worth continuing with this issue at this point, as it might confuse some users, seeing that the meshed statefulsets appeared, but have no data any where.

WDYT?

ihcsim pushed a commit that referenced this issue Feb 7, 2019
Fixes #1983

Signed-off-by: Ivan Sim <ivan@buoyant.io>
ihcsim pushed a commit that referenced this issue Feb 7, 2019
Signed-off-by: Ivan Sim <ivan@buoyant.io>
@ihcsim
Copy link
Contributor

ihcsim commented Feb 7, 2019

Relevant #2224.

@grampelberg
Copy link
Contributor

Also, #2223.

ihcsim pushed a commit that referenced this issue Feb 7, 2019
Signed-off-by: Ivan Sim <ivan@buoyant.io>
ihcsim pushed a commit that referenced this issue Feb 8, 2019
Signed-off-by: Ivan Sim <ivan@buoyant.io>
ihcsim pushed a commit that referenced this issue Feb 8, 2019
Signed-off-by: Ivan Sim <ivan@buoyant.io>
ihcsim pushed a commit that referenced this issue Feb 8, 2019
Signed-off-by: Ivan Sim <ivan@buoyant.io>
ihcsim pushed a commit that referenced this issue Feb 8, 2019
Signed-off-by: Ivan Sim <ivan@buoyant.io>
ihcsim added a commit that referenced this issue Feb 8, 2019
Fixes #1983

Signed-off-by: Ivan Sim <ivan@buoyant.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants