-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add statefulsets to the dashboard and CLI #2234
Conversation
Signed-off-by: Ivan Sim <ivan@buoyant.io>
c4fe1f8
to
96ef90c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! mostly cosmetic comments around statefulset
-> sts
, and sorting resource types.
we are not great about sorting our k8s resource types, but as the number of types grows, i think it becomes more important. not every code path uses exactly the same set of resources, so sort order helps in identifying differences. i noted a few particular sorting locations in the code review, but not all of them. with that in mind, a few guiding principles:
- if a list of resources is already sorted, keep it sorted
- if you encounter code where sorting is not correct, feel empowered to clean it up
- there may be exceptions for UI/doc purposes. the stat help output sorts some exceptional resources at the bottom, but all things being equal, i'd recommend resorting the first 6 items together, then sort the 3 exceptional types together, and then
all
at the bottom.
Valid resource types include:
* daemonsets
* deployments
* namespaces
* pods
* replicationcontrollers
* statefulsets
* authorities (not supported in --from)
* jobs (only supported as a --from or --to)
* services (only supported if a --from is also specified, or as a --to)
* all (all resource types, not supported in --from or --to)
Signed-off-by: Ivan Sim <ivan@buoyant.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 nice!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🚢 👍
This PR adds statefulset resources to the dashboard, CLI and grafana. Note that at present, no TCP metrics will appear. See #2223 and #2224.
The screenshots below show test results with redis and nginx, used to demonstrate http and tcp traffic metrics.
Fixes #1983
Signed-off-by: Ivan Sim ivan@buoyant.io