-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI doesn't complain when given unknown deployments, pods, or paths #49
Comments
pcalcado
added a commit
that referenced
this issue
Jan 25, 2018
Previously, running `$conduit tap` would return a `Unexpected EOF` error when the server wasn't available. This was due to a few problems with the way we were handling errors all the way down the tap server. This change fixes that and cleans some of the protobuf-over-HTTP code. - first step towards #49 - closes #106
This issue is two-thirds resolved. tapwill be fixed in #827
$ conduit tap deploy foo
... stat
$ conduit stat deploy emoji
Error: error calling stat with request: deployment.apps "emoji" not found
Usage:
conduit stat [flags] RESOURCETYPE [RESOURCENAME] get
$ conduit get emojivoto/web-b8f8786b8-49d9j
Error: invalid resource type emojivoto/web-b8f8786b8-49d9j, only pods are allowed as resource types
Usage:
conduit get [flags] pods |
Resolved in #827. |
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this issue
Mar 5, 2019
Metric eviction was introduced to protect against the situation where, over time, the proxy addresses an effectively unbounded number of endpoints. Metrics with endpoint-specific dimensions must be removed over time to prevent a form of memory leak. Eviction is implemented for transport stats. However, transport stats do not yet contain per-endpoint dimensions. The eviction logic is superfluous in this case, since transport metrics are bounded and small. In preparation of changes to transport telemetry, this disables tracking of transport metrics for eviction. This logic will be restored when we support per-endpoint transport metrics.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
For
tap
andstat
, and maybe other commands, specifying a non-existing deployment or pod doesn't result in any kind of error message.E.g.
stat
:and
tap
:This isn't too bad on its surface, but a) it means that e.g. forgetting to put the namespace for
tap deploy
means that the command just hangs forever (this is an easy mistake, and we had a user confused about this in #conduit today), and b) it doesn't match howkubectl
works, e.g.I think these commands should return an error if the specifying pod, deployment, or path (maybe?) is not found.
The text was updated successfully, but these errors were encountered: