Add namespace as a resource type in public-api #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingerf
force-pushed
the
siggy/ns-stats
branch
2 times, most recently
from
cf06fd8 to
ceed490
Compare
The cli and public-api only supported deployments as a resource type. This change adds support for namespace as a resource type in the cli and public-api. This also change includes: - cli statsummary now prints `-`'s when objects are not in the mesh - cli statsummary prints `No resources found.` when applicable - removed `out-` from cli statsummary flags, and analagous proto changes - switched public-api to use native prometheus label types - misc error handling and logging fixes Part of #627 Signed-off-by: Andrew Seigner <siggy@buoyant.io>
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
klingerf
force-pushed
the
siggy/ns-stats
branch
from
14178d2 to
a36dfff
Compare
|
Awesome pairing on this @klingerf !! 💯 |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cli and public-api only supported deployments as a resource type.
This change adds support for namespace as a resource type in the cli and
public-api. This also change includes:
-'s when objects are not in the meshNo resources found.when applicableout-from cli statsummary flags, and analogous proto changesPart of #627
Signed-off-by: Andrew Seigner siggy@buoyant.io
Example cli output:
@kl This is going to conflict with #759. I lifted a couple code snippets from your PR around flag descriptions and filtering out rows on outbound requests. We made identical proto changes. The changes in
controller/api/public/stat_summary.goto accommodate namespaces are significant though, let's figure out a merge strategy.