Skip to content

Commit

Permalink
feat: remove optional private grafana (#1783)
Browse files Browse the repository at this point in the history
  • Loading branch information
merll authored Oct 30, 2024
1 parent 7f1f6d3 commit 9cc2b7e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion helmfile.d/helmfile-60.teams.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,10 @@ releases:
fullnameOverride: {{ $teamId }}-po-grafana
grafana.ini:
"auth.generic_oauth":
role_attribute_path: contains(groups[*], 'admin') && 'Admin' || contains(groups[*], 'platform-admin') && 'Admin' || contains(groups[*], 'team-{{ $teamId }}') && 'Editor'{{ if not ($team | get "managedMonitoring.private" false) }} || 'Viewer'{{- end }}
role_attribute_path: >-
contains(groups[*], 'admin') && 'Admin' ||
contains(groups[*], 'platform-admin') && 'Admin' ||
contains(groups[*], 'team-{{ $teamId }}') && 'Editor'
server:
root_url: https://grafana-{{ $teamId }}.{{ $domain }}
analytics:
Expand Down
3 changes: 3 additions & 0 deletions values-changes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -312,3 +312,6 @@ changes:
relocations:
- 'oidc.adminGroupID': 'oidc.platformAdminGroupID'
- 'oidc.teamAdminGroupID': 'oidc.allTeamsAdminGroupID'
- version: 31
deletions:
- 'teamConfig.{team}.managedMonitoring.private'
3 changes: 0 additions & 3 deletions values-schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1141,9 +1141,6 @@ definitions:
alertmanager:
type: boolean
default: false
private:
type: boolean
default: false
networkPolicy:
ingressPrivate:
title: Enable filtering of ingress traffic inside the cluster
Expand Down

0 comments on commit 9cc2b7e

Please sign in to comment.