Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove optional private grafana #1783

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

merll
Copy link
Contributor

@merll merll commented Oct 29, 2024

This PR drops the per-team setting managedMonitoring.private, which was mainly intended to maintain backwards compatibility to the behavior before the multitenancy became the default, despite being potentially confusing.

Checklist

  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@srodenhuis srodenhuis merged commit 9cc2b7e into main Oct 30, 2024
5 checks passed
@srodenhuis srodenhuis deleted the apl-326-remove-optional-private-grafana branch October 30, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants