Run yq in container to prevent local errors due to versions #268
Assignees
Labels
bug
Something isn't working
Comments
Dunky13
pushed a commit
that referenced
this issue
Jan 6, 2021
yq had to be installed locally due to bin/common.sh yq execution through the otomi bridge. By running the yq commands in a docker container the installation as well as the version are guaranteed. As yq@4 has breaking changes. Now sticky at yq@3 #268
|
Solution suggested in https://github.com/redkubes/otomi-core/tree/yq-error-message |
Dunky13
pushed a commit
that referenced
this issue
Jan 7, 2021
In CI there is no docker(-in-docker) but a local yq is available. So this implementation checks if there is a local yq and is at correct version (3) if so, use local execution, if yq is not installed then use docker and the docker image to run it. If neither is installed, exit en throw error #268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug:
When yq is not installed, or version 4+ is installed the yq commands in
bin/common.shfail due to local execution. Moving the yq execution into a container image would resolve this issueTo Reproduce
yqinstalled. bin/aliasesoaz loginyq: command not foundyq@4installed. bin/aliasesoaz loginunknown command "r" for "yq"Expected behavior:
Just work, without extra local dependencies
Additional context:
Related to #265 - where suggested solution was to throw error, but that would not suffice.
This issue will be resolved using container images
The text was updated successfully, but these errors were encountered: