Feat: run yq in container if necessary #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2021 17:33
yq had to be installed locally due to bin/common.sh yq execution through the otomi bridge. By running the yq commands in a docker container the installation as well as the version are guaranteed. As yq@4 has breaking changes. Now sticky at yq@3 #268
In CI there is no docker(-in-docker) but a local yq is available. So this implementation checks if there is a local yq and is at correct version (3) if so, use local execution, if yq is not installed then use docker and the docker image to run it. If neither is installed, exit en throw error #268
|
Hey, I reviewed exactly the same code at #271 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a function
dyqthat runs theyqcommand in a docker container when the local version is either not installed or not in version 3.This code prefers local execution over containerised execution due to performance. Plus, why run it in a container, when you can run in locally?