Skip to content

Commit

Permalink
test: Fix Firewall update test flake by using less specific selectors (
Browse files Browse the repository at this point in the history
…#10289)

* Fix firewall update test flake by using less specific selectors

* Added changeset: Resolve Firewall update test flake
  • Loading branch information
jdamore-linode authored Mar 18, 2024
1 parent 888cc13 commit 4c366d3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10289-tests-1710457231950.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tests
---

Resolve Firewall update test flake ([#10289](https://github.com/linode/manager/pull/10289))
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,10 @@ describe('update firewall', () => {
addFirewallRules(inboundRule, 'inbound');

// Confirm that the inbound rules are listed on edit page with expected configuration
cy.get('[data-rbd-droppable-context-id="0"]')
cy.findByText(inboundRule.label!)
.should('be.visible')
.closest('li')
.within(() => {
cy.findByText(inboundRule.label!).should('be.visible');
cy.findByText(inboundRule.protocol).should('be.visible');
cy.findByText(inboundRule.ports!).should('be.visible');
cy.findByText(getRuleActionLabel(inboundRule.action)).should(
Expand All @@ -233,10 +233,10 @@ describe('update firewall', () => {
addFirewallRules(outboundRule, 'outbound');

// Confirm that the outbound rules are listed on edit page with expected configuration
cy.get('[data-rbd-droppable-context-id="1"]')
cy.findByText(outboundRule.label!)
.should('be.visible')
.closest('li')
.within(() => {
cy.findByText(outboundRule.label!).should('be.visible');
cy.findByText(outboundRule.protocol).should('be.visible');
cy.findByText(outboundRule.ports!).should('be.visible');
cy.findByText(getRuleActionLabel(outboundRule.action)).should(
Expand Down

0 comments on commit 4c366d3

Please sign in to comment.