test: Fix Firewall update test flake by using less specific selectors #10289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
requested review from
cliu-akamai
and removed request for
a team
jdamore-linode
requested review from
bnussman-akamai and
hkhalil-akamai
and removed request for
a team
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Mar 18, 2024
hkhalil-akamai
approved these changes
Mar 18, 2024
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes an occasional test failure in
update-firewall.spec.tsby using a less specific selector to find the inbound/outbound rules in the list.Changes 🔄
<li />elementHow to test 🧪
yarn cy:run -s "cypress/e2e/core/firewalls/update-firewall.spec.ts"(Repeat as needed to gain confidence that flake is resolved)
As an Author I have considered 🤔
Check all that apply