-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-8607] - Change notification tax_id_invalid
to tax_id_verifying
#10967
Conversation
tax_id_invalid
to tax_id_verifying
tax_id_invalid
to tax_id_verifying
Coverage Report: ✅ |
packages/manager/src/features/Billing/BillingPanels/ContactInfoPanel/ContactInformation.tsx
Outdated
Show resolved
Hide resolved
@jdamore-linode Any idea why I'm getting a failure for I think it's safe to merge this, but just looking for confirmation |
@jaalah-akamai Mind merging in the latest from |
Cloud Manager E2E Run #6602
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #6602
|
Run duration | 24m 48s |
Commit |
e9e3495596: change: [M3-8607] - Change notification `tax_id_invalid` to `tax_id_verifying` (...
|
Committer | Jaalah Ramos |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
409
|
View all changes introduced in this branch ↗︎ |
Description 📝
Renames the
tax_id_invalid
notification totax_id_verifying
to represent what it actually does. The eventtax_id_invalid
remains unchanged.Changes 🔄
Target release date 🗓️
Note
In conjunction with APINext pr
7001
Preview 📷
No visual changes - ensure when changing tax id you see the loading icon. See recording in this PR for details #10928
How to test 🧪
To test, this requires you to run DevEnv pointing to the branch for apinext PR
7001
As an Author I have considered 🤔
Check all that apply