-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8617] - Autocomplete Popper re-rendering causing test failures #10978
fix: [M3-8617] - Autocomplete Popper re-rendering causing test failures #10978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @bnussman-akamai! 🙏
I'm really confident in this implementation: plan-selection.spec.ts
passes 50/50 times, tests in core/linodes
are passing, and I'm not seeing any regressions in any of the Autocompletes I've looked at in the app.
If you're open to it, we can take this out of draft and make this the PR for M3-8617, and I can update #10976 to contain only the M3-8602 fixes (the before
-> beforeEach
change in plan-selection.spec.ts
). Or we can include the spec changes here and just close #10976 altogether
I really appreciate you taking a closer look and proposing this solution! Thanks again Banks!
This sounds good to me! I'll update this PR to reflect M3-8617 @jdamore-linode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phone Number select & Autocomplete fields in Cloud look good ✅
Code review ✅
@bnussman Very nice! I seriously didn't understand the power of the |
Description 📝
Should hopefully fix the test failures we've recently begun seeing throughout the test suite when Cypress tries to interact with Autocompletes:
Provides an alternative to @jdamore-linode 's fix a90aba8 that was originally in fix: [M3-8602] - Fix
plan-selection.spec.ts
test failures on retries #10976This PR reverts some changes made in refactor: [M3-6908] - Replace react-select in Profile #10780 in favor of using MUI's built in
slotProps
to customize components that make up our AutoCompleteHow to test 🧪