Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [M3-8707] - Move Tooltip component to UI package #11125

Merged
merged 6 commits into from
Oct 24, 2024
Merged

refactor: [M3-8707] - Move Tooltip component to UI package #11125

merged 6 commits into from
Oct 24, 2024

Conversation

hkhalil-akamai
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai commented Oct 17, 2024 •
edited
Loading

Description 📝

Moves the Tooltip component to the @linode/ui package and updates existing imports.

Changes 🔄

  • Copy Tooltip component and story to @linode/ui package
  • Update existing imports

How to test 🧪

Verify the usages of Tooltip in the following locations:
Screenshot 2024-10-17 at 5 33 07 PM

@hkhalil-akamai hkhalil-akamai self-assigned this Oct 17, 2024
@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner October 17, 2024 21:40
@hkhalil-akamai hkhalil-akamai requested review from dwiley-akamai and coliu-akamai and removed request for a team October 17, 2024 21:40
@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner October 22, 2024 18:07
@hkhalil-akamai hkhalil-akamai requested review from AzureLatte and removed request for a team October 22, 2024 18:07
dwiley-akamai
dwiley-akamai reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tooltips in Cloud look good ✅
Code review ✅

Looks like there's a unit test that needs adjusting:

Screenshot 2024-10-22 at 5 24 44 PM

And I'm seeing this when running Storybook locally, I'll try clearing things to see if that fixes it

Screenshot 2024-10-22 at 5 48 15 PM

packages/ui/src/components/Tooltip.stories.tsx Show resolved Hide resolved
@hkhalil-akamai
Copy link
Contributor Author

I'm seeing this when running Storybook locally, I'll try clearing things to see if that fixes it

@dwiley-akamai were you able to fix this issue? I'm unable to reproduce locally.

@dwiley-akamai
Copy link
Contributor

@dwiley-akamai were you able to fix this issue? I'm unable to reproduce locally.

I was not. I deleted node_modules and reinstalled everything but that didn't work. If no one else is seeing it we can attribute it to a local cache/config issue

bnussman-akamai
bnussman-akamai approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👏

Existing to see us finally build @linode/ui!

Glad to see that, with this setup, hot reloading is still working as expected!

@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label Oct 24, 2024
@github-actions GitHub Actions
Copy link

Coverage Report: ❌
Base Coverage: 86.99%
Current Coverage: 86.98%

coliu-akamai
coliu-akamai approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks Hussain! 🎉

✅ tooltips in Cloud
✅ code

I'm also unable to reproduce the storybook issue locally @dwiley-akamai

@hkhalil-akamai hkhalil-akamai merged commit f3d86c0 into linode:develop Oct 24, 2024
23 checks passed
@hkhalil-akamai hkhalil-akamai deleted the M3-8707-tooltip-UI-package branch October 24, 2024 18:10
@cypress Cypress
Copy link

cypress bot commented Oct 24, 2024 •
edited
Loading

Cloud Manager E2E    Run #6731

Run Properties:  status check passed Passed #6731  •  git commit f3d86c040f: refactor: [M3-8707] - Move `Tooltip` component to UI package (#11125)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6731
Run duration 26m 39s
Commit git commit f3d86c040f: refactor: [M3-8707] - Move `Tooltip` component to UI package (#11125)
Committer Hussain Khalil
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 445
View all changes introduced in this branch ↗︎

@pmakode-akamai pmakode-akamai mentioned this pull request Oct 25, 2024
Merged
@jaalah-akamai jaalah-akamai mentioned this pull request Nov 7, 2024
Merged
@coliu-akamai coliu-akamai mentioned this pull request Nov 12, 2024
Merged
12 tasks
@hana-akamai hana-akamai mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliu-akamai coliu-akamai coliu-akamai approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@dwiley-akamai dwiley-akamai dwiley-akamai approved these changes

@AzureLatte AzureLatte Awaiting requested review from AzureLatte AzureLatte was automatically assigned from linode/frontend-sdet

Assignees

@hkhalil-akamai hkhalil-akamai

Labels
Approved Multiple approvals and ready to merge! Modularization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hkhalil-akamai @dwiley-akamai @bnussman-akamai @coliu-akamai