Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UIE-8338] dbaas IP validation should display updated error message that includes IPV6 #11414

Conversation

smans-akamai
Copy link
Contributor

@smans-akamai smans-akamai commented Dec 12, 2024

Description 📝

In DBaaS Create and Settings, Manage Access IP fields should display an updated validation error message that includes IPv6 when both IPv6 and IPv4 are available.

Changes 🔄

  • DBaaS Create and Setting Manage Access IP field validation error messages have been updated to include IPv6 when available.

Target release date 🗓️

1/14/25

Preview 📷

Before After
db-settings-manage-access-before db-settings-manage-access-after
db-create-before db-create-after

How to test 🧪

Prerequisites

  • Have access to Databases tab
  • To view changes in DBaaS Create, have dbaasV2 feature flag set to GA
  • To view changes in DBaaS Settings Managed access drawer, have a new database cluster available.

Reproduction steps

  • For DBaaS Create, enter an invalid value into the Manage Access Allowed IP field and see that the error message only mentions requiring a valid IPv4 address even though IPv6 is also accepted.
  • For DBaaS Settings, access Settings for a new database cluster. Then click the Manage Access button to open the drawer. Then enter invalid data and see that the error message only mentions requiring a valid IPv4 address even though IPv6 is also accepted.

Verification steps

  • Using the reproduction steps above, confirm that when IPv6 is available, the new validation error message is displayed for DBaaS Create and Settings Managed Access fields. "Must be a valid IPv6 or IPv4 address."
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@smans-akamai smans-akamai requested a review from a team as a code owner December 12, 2024 22:08
@smans-akamai smans-akamai requested review from carrillo-erik and abailly-akamai and removed request for a team December 12, 2024 22:08
@smans-akamai smans-akamai force-pushed the UIE-8338-dbaas-fix-manage-access-add-ip-field-error-message branch from 152be78 to 8855daf Compare December 12, 2024 22:15
@smans-akamai smans-akamai force-pushed the UIE-8338-dbaas-fix-manage-access-add-ip-field-error-message branch from 8855daf to be699b5 Compare December 12, 2024 22:20
Copy link

github-actions bot commented Dec 12, 2024

Coverage Report:
Base Coverage: 86.78%
Current Coverage: 86.78%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 469 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing469 Passing2 Skipped97m 38s

@cpathipa cpathipa added the DBaaS Relates to Database as a Service label Dec 13, 2024
@cpathipa cpathipa removed the request for review from carrillo-erik December 13, 2024 16:13
@cpathipa cpathipa merged commit 6e403e9 into linode:develop Dec 13, 2024
23 checks passed
Copy link

cypress bot commented Dec 13, 2024

Cloud Manager E2E    Run #6968

Run Properties:  status check passed Passed #6968  •  git commit 6e403e9ec0: fix: [UIE-8338] dbaas IP validation should display updated error message that in...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6968
Run duration 27m 16s
Commit git commit 6e403e9ec0: fix: [UIE-8338] dbaas IP validation should display updated error message that in...
Committer smans-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 466
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants