-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix: Incorrect Region Options #11449
hotfix: Incorrect Region Options #11449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you 🥲
Coverage Report: ❌ |
9bf1c3a
Cloud Manager UI test results🔺 1 failing test on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and discussed during our mini-dogfooding session -- region options look as expected in Linode Create flow and in OBJ flows ✅
* add initial fix * version bump and changelog update * POC of better fix * clean up * feedback - use prop approach * feedback - use prop approach * feedback - use prop approach --------- Co-authored-by: Banks Nussman <banks@nussman.us>
Description 📝
Bug Summary 🐛
manager/packages/manager/src/components/RegionSelect/RegionSelect.utils.tsx
Lines 43 to 45 in 0b0fa66
The Fix 🔧
currentCapability === 'Object Storage'
to the new one-off logic so that it only applies to Object Storage region selectsPreview 📷
Before
sg-sin-2
is shown as both a core region and a distributed region 😳After
sg-sin-2
only shows up as a core regionHow to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅