Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Incorrect Region Options #11449

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Dec 20, 2024

Description 📝

Bug Summary 🐛

  • One-off logic was added for Object Storage Gen2, but that logic was applied to all region selects throughout Cloud Manager resulting in users seeing incorrect region options outside of Object Storage 🌎

if (isObjectStorageGen2Enabled && WHITELISTED_REGIONS.has(region.id)) {
return true;
}

The Fix 🔧

  • Add a condition to check that currentCapability === 'Object Storage' to the new one-off logic so that it only applies to Object Storage region selects

Preview 📷

Before

sg-sin-2 is shown as both a core region and a distributed region 😳

After

sg-sin-2 only shows up as a core region

How to test 🧪

  • Check Region Selects throughout Cloud Manager
    • Verify correct regions are shown
    • Verify that on Linode Create, regions are not duplicated under "Core" and "Distributed"
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added the Hotfix Hotfix: This is going to staging label Dec 20, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner December 20, 2024 16:26
@bnussman-akamai bnussman-akamai requested review from dwiley-akamai and harsh-akamai and removed request for a team December 20, 2024 16:26
coliu-akamai
coliu-akamai previously approved these changes Dec 20, 2024
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🥲

jdamore-linode
jdamore-linode previously approved these changes Dec 20, 2024
cpathipa
cpathipa previously approved these changes Dec 20, 2024
Copy link

github-actions bot commented Dec 20, 2024

Coverage Report:
Base Coverage: 86.85%
Current Coverage: 86.84%

@coliu-akamai coliu-akamai self-requested a review December 20, 2024 17:10
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing465 Passing2 Skipped111m 55s

Details

Failing Tests
SpecTest
linode-config.spec.tsEnd-to-End » Clones a config

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts"

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and discussed during our mini-dogfooding session -- region options look as expected in Linode Create flow and in OBJ flows ✅

@bnussman-akamai bnussman-akamai merged commit 6c208ca into linode:staging Dec 20, 2024
22 of 23 checks passed
dmcintyr-akamai pushed a commit to dmcintyr-akamai/manager that referenced this pull request Jan 9, 2025
* add initial fix

* version bump and changelog update

* POC of better fix

* clean up

* feedback - use prop approach

* feedback - use prop approach

* feedback - use prop approach

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hotfix Hotfix: This is going to staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants