Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.133.2 - staging → master #11451

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Release v1.133.2 - staging → master #11451

merged 2 commits into from
Dec 20, 2024

Conversation

bnussman-akamai
Copy link
Member

Fixed:

  • Incorrectly displayed region options (#11449)

@bnussman-akamai @bnussman
hotfix: Incorrect Region Options (#11449)
6c208ca 
* add initial fix

* version bump and changelog update

* POC of better fix

* clean up

* feedback - use prop approach

* feedback - use prop approach

* feedback - use prop approach

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
@bnussman-akamai bnussman-akamai added Release Cloud Manager releases Hotfix Hotfix: This is going to staging labels Dec 20, 2024
@bnussman-akamai bnussman-akamai self-assigned this Dec 20, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner December 20, 2024 19:31
cpathipa
cpathipa approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staging LGTM!

coliu-akamai
coliu-akamai approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good on staging - thank you

hkhalil-akamai
hkhalil-akamai approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this @bnussman-akamai

@bnussman-akamai bnussman-akamai merged commit 1f0844b into master Dec 20, 2024
44 of 45 checks passed
@cypress Cypress
Copy link

cypress bot commented Dec 20, 2024 •
edited
Loading

Cloud Manager E2E    Run #7063

Run Properties:  status check failed Failed #7063  •  git commit 5b0c1fc88e: Merge branch 'master' into staging
Project Cloud Manager E2E
Branch Review staging
Run status status check failed Failed #7063
Run duration 23m 39s
Commit git commit 5b0c1fc88e: Merge branch 'master' into staging
Committer Banks Nussman
View all properties for this run ↗︎
Test results
Tests that failed  Failures 23
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 443
View all changes introduced in this branch ↗︎

Tests for review

Failed  linodes/smoke-delete-linode.spec.ts • 4 failed tests

View Output Video

Test Artifacts
delete linode > deletes linode from linode details page Screenshots Video
delete linode > deletes linode from setting tab in linode details page Screenshots Video
delete linode > deletes linode from linode landing page Screenshots Video
delete linode > deleting multiple linodes with action menu Screenshots Video
Failed  linodes/clone-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Failed  stackscripts/create-stackscripts.spec.ts • 1 failed test

View Output Video

Test Artifacts
Create stackscripts > creates a StackScript with Any/All target image Screenshots Video
Failed  linodes/rebuild-linode.spec.ts • 2 failed tests

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Image Screenshots Video
rebuild linode > rebuilds a linode from Community StackScript Screenshots Video
Failed  firewalls/update-firewall.spec.ts • 3 failed tests

View Output Video

Test Artifacts
update firewall > updates a firewall's linodes and rules Screenshots Video
update firewall > updates a firewall's status Screenshots Video
update firewall > updates a firewall's label Screenshots Video

The first 5 failed specs are shown, see all 13 specs in Cypress Cloud.

Flakiness  linodes/update-linode-labels.spec.ts • 1 flaky test

View Output Video

Test Artifacts
update linode label > updates a linode label from the "Settings" tab Screenshots Video
Flakiness  linodes/resize-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
resize linode > resizes a linode by increasing size: cold migration Screenshots Video
Flakiness  volumes/delete-volume.spec.ts • 1 flaky test

View Output Video

Test Artifacts
volume delete flow > deletes a volume Screenshots Video
Flakiness  firewalls/create-firewall.spec.ts • 1 flaky test

View Output Video

Test Artifacts
create firewall > creates a firewall without a linode Screenshots Video

@github-actions GitHub Actions
Copy link

Coverage Report: ❌
Base Coverage: 86.85%
Current Coverage: 86.84%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliu-akamai coliu-akamai coliu-akamai approved these changes

@hkhalil-akamai hkhalil-akamai hkhalil-akamai approved these changes

@cpathipa cpathipa cpathipa approved these changes

@carrillo-erik carrillo-erik Awaiting requested review from carrillo-erik carrillo-erik is a code owner automatically assigned from linode/frontend

Assignees

@bnussman-akamai bnussman-akamai

Labels
Hotfix Hotfix: This is going to staging Release Cloud Manager releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @cpathipa @hkhalil-akamai @coliu-akamai