-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix: DC-specific pricing -- monthly price decimals and invoice region column #9759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far!
export const MAGIC_DATE_THAT_DC_SPECIFIC_PRICING_WAS_IMPLEMENTED = | ||
'2023-10-05 00:00:00Z'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have to exist in 2 places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, unless you know of a way to import from src/utilities/pricing/constants
? We do have a M3 ticket in the backlog to take a look at de-duplicating constants in cypress tests, which we've run into often in this file, as discussed in another ticket. It looks like I could import from @src/constants
in a test file, but couldn't do the same with the pricing file without an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming all updates look good - but left a comment regarding the overall implementation of MAGIC_DATE_THAT_DC_SPECIFIC_PRICING_WAS_IMPLEMENTED
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
- pricing are showing properly in plan selection and summaries ✅
- region is hidden ✅
packages/manager/cypress/e2e/core/kubernetes/lke-update.spec.ts
Outdated
Show resolved
Hide resolved
e6811aa
to
2b7f786
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I started the e2es locally so I'll let you know if I see an issues there |
Looks like we're expecting create-linode.spec.ts.mp4 |
Description 📝
There are two issues with DC-specific pricing:
$n/mo
) are now displaying inconsistently -- most often with one decimal place, but in at least one instance (resize node pool drawer, 2GB linode) with way too many decimal placesMajor Changes 🔄
Preview 📷
How to test 🧪
2023-10-31T18:04:01
and the go to http://localhost:3000/account/billing/invoices/1234:e2es should pass, but I've been seeing issues with the LKE smoke tests locally due to some odd behavior with the region select scrolling out of view and returning
no results
after a selection is made -- that doesn't replicate in the UI, so not sure what is going on here.