-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.401.1 - staging → master #9761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement fake region and logic * Bump package * Cleanup * File renaming * Changelog entry * Changelog entry update * Improve code quality * Increase width of volume create fields * Increase width of volume create fields - mobile * Consolidate API * Exclude paths logic
…ion column (#9759) * Hide regions in past invoices * Display two decimal places for monthly prices in plan selections * Display two decimal places in lke node pools drawers * Clean up invoice util * Update e2es * Fix typo in test comments * Use two decimals only if not an int * Add unit test coverage for util * Unskip a test I forgot to reenable * Update changelog * Fix linting warning
abailly-akamai
approved these changes
Oct 5, 2023
2 flaky tests on run #5236 ↗︎
Details:
linode-config.spec.ts • 1 flaky test
rescue-linode.spec.ts • 1 flaky test
Review all test suite changes for PR #9761 ↗︎ |
mjac0bs
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the following:
- User has the tokyo-enable admin flag (soldOutTokyo on or off)
- User should see the Tokyo region menu item
- User should not see this option as disabled
- User should not see the fake Tokyo option
- User should be able to create a resource in Tokyo
- User should not see Tokyo at /object-storage/buckets/create
- User does not have the tokyo-enable admin flag
flag off:
- User should not see the Tokyo option at all
- User should not be able to create a resource in Tokyo
- User should not see Tokyo at /object-storage/buckets/create
flag
on:
- User should see the fake (disabled) Tokyo menu option
- User should be able to hover the option and see a tooltip with a description and a link
- User should be able to navigate to https://www.linode.com/blog/linode/tokyo-region-availability-update/ by clicking on a link
- User should not be able to create a resource in Tokyo
- User should not see Tokyo at /object-storage/buckets/create
Also confirmed DC pricing:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog - v1.104.1
Fixed: