Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.401.1 - staging → master #9761

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Release v1.401.1 - staging → master #9761

merged 3 commits into from
Oct 5, 2023

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Oct 5, 2023

Changelog - v1.104.1

Fixed:

  • Add disabled Tokyo RegionSelect menu entry (#9758)
  • Display DC-specific monthly prices to two decimal places and hide blank Region column on past invoices (#9759)

abailly-akamai and others added 2 commits October 5, 2023 12:04
* Implement fake region and logic

* Bump package

* Cleanup

* File renaming

* Changelog entry

* Changelog entry update

* Improve code quality

* Increase width of volume create fields

* Increase width of volume create fields - mobile

* Consolidate API

* Exclude paths logic
…ion column (#9759)

* Hide regions in past invoices

* Display two decimal places for monthly prices in plan selections

* Display two decimal places in lke node pools drawers

* Clean up invoice util

* Update e2es

* Fix typo in test comments

* Use two decimals only if not an int

* Add unit test coverage for util

* Unskip a test I forgot to reenable

* Update changelog

* Fix linting warning
@cpathipa cpathipa requested a review from a team as a code owner October 5, 2023 17:20
@cpathipa cpathipa added the Release Cloud Manager releases label Oct 5, 2023
@cpathipa cpathipa self-assigned this Oct 5, 2023
@cypress
Copy link

cypress bot commented Oct 5, 2023

2 flaky tests on run #5236 ↗︎

0 236 0 0 Flakiness 2

Details:

hotfix: DC-specific pricing -- monthly price decimals and invoice region column ...
Project: Cloud Manager E2E Commit: d1d726c4ac
Status: Passed Duration: 16:11 💡
Started: Oct 5, 2023 5:17 PM Ended: Oct 5, 2023 5:33 PM
Flakiness  linode-config.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Linode Config > Edits an existing config Output Screenshots Video
Flakiness  rescue-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Rescue Linodes > Cannot reboot a provisioning Linode into rescue mode Output Screenshots Video

Review all test suite changes for PR #9761 ↗︎

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the following:

  1. User has the tokyo-enable admin flag (soldOutTokyo on or off)
  • User should see the Tokyo region menu item
  • User should not see this option as disabled
  • User should not see the fake Tokyo option
  • User should be able to create a resource in Tokyo
  • User should not see Tokyo at /object-storage/buckets/create
  1. User does not have the tokyo-enable admin flag
    flag off:
  • User should not see the Tokyo option at all
  • User should not be able to create a resource in Tokyo
  • User should not see Tokyo at /object-storage/buckets/create

flag
on:

  • User should see the fake (disabled) Tokyo menu option
  • User should be able to hover the option and see a tooltip with a description and a link
  • User should be able to navigate to https://www.linode.com/blog/linode/tokyo-region-availability-update/ by clicking on a link
  • User should not be able to create a resource in Tokyo
  • User should not see Tokyo at /object-storage/buckets/create

Also confirmed DC pricing:

  • Monthly decimal places to two places unless already an integer:
    Screenshot 2023-10-05 at 10 24 15 AM

  • Invoice without regions:
    Screenshot 2023-10-05 at 10 47 45 AM

@cpathipa cpathipa merged commit 73bcf62 into master Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Cloud Manager releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants