-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7272] - Disable Public IP Address for VPC only Linode #9899
feat: [M3-7272] - Disable Public IP Address for VPC only Linode #9899
Conversation
packages/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/LinodeIPAddressRow.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPs are disabled for VPCs where mentioned in the testing steps and not disabled otherwise and unit test looks good.
One thing: in dark mode, the disabled IP Addresses table row within the Linode Details > Network tab seems like it probably has a theme styling issue. Light mode is fine!
Screen.Recording.2023-11-14.at.11.35.56.AM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to finish combing through the code tomorrow but the functionality looks good:
The Public IP Address column in the Linodes landing table should be disabled and there should be a tooltip ✅
The Public IP Addresses and Access sections in the Linode's details page should be disabled and there should be a tooltip ✅
The Public IPv4 row in the Linode's details -> Network tab -> IP Addresses table should be disabled and there should be a tooltip ✅
packages/manager/.changeset/pr-9899-upcoming-features-1699911388781.md
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/PublicIpsUnassignedTooltip.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/PublicIpsUnassignedTooltip.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from one small comment. There was also a test failure for smoke-linode-landing-table.spec.ts
-- probably related to the Copy icon for IPs? Approving pending investigating that
...s/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/LinodeNetworkingActionMenu.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending the previously mentioned comments are addressed. The e2e fails because it's looking for IP Addresses
as an exact match (L396) and we now have Public IP Addresses
:
Thanks for fixing the dark mode disabled address row. Confirmed disabled states for all three areas look good in both light and dark modes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good (one nitpicky comment) + unit tests pass! ✅
I'm honestly very confused about the configuration issue -- I changed the configs for both debian-miami and debian-lax (not 001, that one was already good) a bunch, and eventually the tooltips/disabled public IP started working... not sure what was going on 🤔 😖
I haven't been able to repeat the issue, so it could have been a one time fluke??
packages/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/LinodeIPAddressRow.tsx
Outdated
Show resolved
Hide resolved
@coliu-akamai Could it have been bc the "Assign a public IPv4 address" was checked? 🤔 |
@hana-linode I don't think so bc if I'd had a public IPv4 address assigned for a Linode checked from the start, that checkbox should have been prechecked when I open up the edit config panel right? 😖 It honestly feels like a fluke bc I'm not getting the same issue now no matter what I do - maybe my computer just decided to act up? |
## Description 📝 We are grabbing configs for every Linode in the Linodes landing page to check if it is a VPC-only Linode which does not scale well (same problem as the VPC Linodes landing column). This PR reverts the Linodes landing portion of #9899 and adds a warning banner ## Changes 🔄 - Revert disabling of the Public IP Address column in the Linodes landing table for VPC-only Linodes - Add warning banner to the Linodes landing page ## How to test 🧪 ### Prerequisites - Ensure your account has vpc customer tags ### Reproduction steps - Go to `/linodes` and filter your Network tab by `configs`. You should see a configs request for each Linode you have ### Verification steps - Go to `/linodes` and filter your Network tab by `configs` - You should no longer see a configs request for each Linode you have - You should see a warning banner
Description 📝
Visually disable Public IP addresses for VPC-only Linodes and add tooltip explanation.
A VPC-only Linode is a Linode that has at least one config interface with
primary
set totrue
and purposevpc
and noipv4.nat_1_1
value.Changes 🔄
useVPCConfigInterface
to share logicPreview 📷
How to test 🧪
Prerequisites
assign a public IPv4 address
checkbox is unchecked)Verification steps
For the VPC-only Linode
As an Author I have considered 🤔
Check all that apply