-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-7485] - Revert Disable Public IP for Linodes Landing #9933
change: [M3-7485] - Revert Disable Public IP for Linodes Landing #9933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- confirmed /configs request no longer made ✅
- confirmed expected behavior (IP no longer disabled on Linodes Landing page, still disabled on Linode Details page if Linode is 'VPC only linode') ✅
would we need a changeset for this (or should we edit the changeset of the original pr)?
@coliu-akamai Since the original PR hasn't been released yet, I opted to edit the changeset |
awesome thanks @hana-linode! 🚀 |
Also to add, we should prob let Kurt/Andrew know about this change so they're aware. In general seems like anything in the Linodes landing page that depends on the configs just won't be possible for now 😢 |
Added an additional banner, can you take another look? @coliu-akamai @bnussman-akamai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ confirmed banner appears
✅ reconfirmed existing behavior!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, do we really need this banner?
A user who doesn't intend to use VPC signs up for Linode and sees that banner first thing when they load Cloud Manager.
I don't like the experience of showing this banner to every user who has access to VPC...
@bnussman-akamai The banner was a decision by Kurt (Product Manager for VPC) to reduce confusion/concerns around security vulnerabilities/misconfiguration since it's no longer viable to visually disable the IP address field |
Banner is present and filtering the network tab renders the expected results. |
Description 📝
We are grabbing configs for every Linode in the Linodes landing page to check if it is a VPC-only Linode which does not scale well (same problem as the VPC Linodes landing column). This PR reverts the Linodes landing portion of #9899 and adds a warning banner
Changes 🔄
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
/linodes
and filter your Network tab byconfigs
. You should see a configs request for each Linode you haveVerification steps
/linodes
and filter your Network tab byconfigs
As an Author I have considered 🤔
Check all that apply