Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pruned files to CKAN installation filters #41

Conversation

HebaruSan
Copy link
Contributor

Hi @linuxgurugamer!

  • The perma-prune button now updates the CKAN installation filters from Global install filters KSP-CKAN/CKAN#3458 if a CKAN folder is found in the game root, which will tell CKAN that it should not consider perma-pruned files as missing because the user chose to remove them. This will prevent CKAN v1.35.0 and later from prompting the user to reinstall the mods that the pruned files came from.
    Noticed thanks to @Sinomen's comments on [Feature] Ability to suppress missing file checks for user-deleted files KSP-CKAN/CKAN#4205.
  • There are a bunch of seemingly unused duplicate copies of some of the files in a folder called EditorWindows. This was very confusing when I first cloned the repo; it was not clear which files were inactive and which ones I should edit until I dug into the .csproj file. I have deleted these to prevent this confusion for future developers; they can still be accessed in the git log history, if needed.

I'll probably PM you on Discord and the forum regarding this to make sure you see it. Apologies in advance for the duplication. Cheers!

@linuxgurugamer linuxgurugamer merged commit c4a7594 into linuxgurugamer:master Sep 30, 2024
@HebaruSan HebaruSan deleted the feature/copy-pruned-to-clipboard branch September 30, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants