Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update the ci to use basemaps/server container for screenshots and smoke test #984

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

Wentao-Kuang
Copy link
Contributor

@Wentao-Kuang Wentao-Kuang commented Sep 29, 2024

Motivation

We should use server container instead of cli container when running a basemaps server.
Because the serve commands in the cli container was legacy before we got the server container and is deprecated, as it required extra dependencies like lerc and basemaps/landing linz/basemaps#3348.

Modifications

Use server container for screenshots and smoke tests

Verification

@Wentao-Kuang Wentao-Kuang added this pull request to the merge queue Oct 2, 2024
Merged via the queue into master with commit 409b073 Oct 2, 2024
6 of 7 checks passed
@Wentao-Kuang Wentao-Kuang deleted the build/use-server-container branch October 2, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants