fix(server): Add lerc external into server package. #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
Sep 27, 2024
blacha
reviewed
Sep 27, 2024
blacha
reviewed
Sep 29, 2024
Co-authored-by: Blayne Chard <bchard@linz.govt.nz>
blacha
approved these changes
Sep 29, 2024
github-merge-queue bot
pushed a commit
to linz/basemaps-config
that referenced
this pull request
Oct 2, 2024
… and smoke test (#984) ### Motivation We should use `server` container instead of `cli` container when running a basemaps server. Because the `serve` commands in the `cli` container was legacy before we got the server container and is deprecated, as it required extra dependencies like `lerc` and `basemaps/landing` linz/basemaps#3348. ### Modifications Use server container for screenshots and smoke tests ### Verification <!-- TODO: Say how you tested your changes. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It looks like we are missing lerc in the server cli.
https://github.com/linz/basemaps-config/actions/runs/11061552896/job/30734619452?pr=970
Modifications
Add the
lercinto server and cli packageVerification
Local build server container with lerc uninstall vs installed.
UNINSTALL
INSTALLED
Test Screenshot with fixed container