Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Add lerc external into server package. #3348

Merged
merged 6 commits into from
Sep 29, 2024
Merged

fix(server): Add lerc external into server package. #3348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4478917
Add lerc external into server package.
Wentao-Kuang Sep 26, 2024
8f3212a
Add lerc into cli package
Wentao-Kuang Sep 26, 2024
e229587
Install lerc into container
Wentao-Kuang Sep 27, 2024
c06cfe2
Install lerc as dependecies for server
Wentao-Kuang Sep 27, 2024
646c04f
Add note to deprecate server in the cli container
Wentao-Kuang Sep 29, 2024
d1d602f
Update packages/cli/src/cli/server/action.serve.ts
Wentao-Kuang Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
"outfile": "dist/index.cjs",
"external": [
"sharp",
"pino-pretty"
"pino-pretty",
"lerc"
]
}
],
Expand Down
1 change: 1 addition & 0 deletions packages/cli/src/cli/server/action.serve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {

const DefaultPort = 5000;

/** @deprecated 2024-09 Use the basemaps/server container directly now, and deprecate this later. */
export class CommandServe extends CommandLineAction {
config!: CommandLineStringParameter;
assets!: CommandLineStringParameter;
Expand Down
6 changes: 4 additions & 2 deletions packages/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
"executable": true,
"external": [
"pino-pretty",
"sharp"
"sharp",
"lerc"
]
}
],
Expand All @@ -47,7 +48,8 @@
"@basemaps/landing": "^7.0.0"
},
"dependencies": {
"sharp": "^0.33.0"
"sharp": "^0.33.0",
"lerc": "^4.0.4"
},
"devDependencies": {
"@basemaps/config": "^7.7.0",
Expand Down
Loading