Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6460]apps/*/assets/*: update render function syntax| deps: update a4 hash t… #4489

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Sep 20, 2022

…o working PR
Dependent on liqd/adhocracy4#1217

Tested:

  • Poll dashboard
    ! button styling broken
    ! popper menu styling broken and lib unsupported now
    ! moved questions don't save (known issue)
    NTH: re-structure file to separate dashboard and user components
    NTH: re-implement the loading animation for resultes
  • Poll User
  • Comments (not with functional components)
    ! styling of copy modal wrong
    ! buttons wrong styling
    ! cannot save answer
    ! linking doesn't work-no scrolling or styling
    ! constant loading icon
  • Rating
  • PlansMap
  • PlansMap Filter
    ! filters are not selected immediately every time, behaviour is erratic
  • Documents dashboard
  • Documents user
  • Interactive Event dashboard
  • Interactive Event user
    ! button styling wrong
    ! intro page when event not running seems to be skipped but that isn't react?
    NTH: implement loading animation if we do it in polls
  • Following
  • Alert
  • Budgeting List
  • Vote (Budgeting)
    ! button styling broken

Sorry, something went wrong.

@philli-m philli-m changed the title apps/*/assets/*: update render fnction syntax| deps: update a4 hash t… [#6460]apps/*/assets/*: update render fnction syntax| deps: update a4 hash t… Sep 20, 2022
@philli-m philli-m force-pushed the pm-2022-09-react18 branch 2 times, most recently from 387f0e7 to b4a7898 Compare September 21, 2022 07:18
@philli-m philli-m changed the title [#6460]apps/*/assets/*: update render fnction syntax| deps: update a4 hash t… [#6460]apps/*/assets/*: update render function syntax| deps: update a4 hash t… Sep 21, 2022
@philli-m philli-m added the Dev: A4 depending PR or issue dependent on A4 label Sep 22, 2022
@philli-m
Copy link
Contributor Author

philli-m commented Sep 22, 2022

I have added the list to the story so we can work on it from there.
edit: the styling issues I have added to the list but they are due to the removal of planifolio, will create issue and remove from list

Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! only one comment about the map setup

@philli-m philli-m requested a review from goapunk September 26, 2022 12:04
@goapunk goapunk enabled auto-merge (rebase) September 26, 2022 12:08
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, looks good to me!

@goapunk goapunk merged commit 97f14fa into main Sep 26, 2022
@goapunk goapunk deleted the pm-2022-09-react18 branch September 26, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: A4 depending PR or issue dependent on A4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants