-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#6460]apps/*/assets/*: update render function syntax| deps: update a4 hash t… #4489
Conversation
387f0e7
to
b4a7898
Compare
b4a7898
to
8fcfec2
Compare
I have added the list to the story so we can work on it from there. |
4cdae8d
to
3008db3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! only one comment about the map setup
3008db3
to
f501c43
Compare
f501c43
to
d9f9b1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, looks good to me!
…o working PR
Dependent on liqd/adhocracy4#1217
Tested:
! button styling broken
! popper menu styling broken and lib unsupported now
! moved questions don't save (known issue)
NTH: re-structure file to separate dashboard and user components
NTH: re-implement the loading animation for resultes
! styling of copy modal wrong
! buttons wrong styling
! cannot save answer
! linking doesn't work-no scrolling or styling
! constant loading icon
! filters are not selected immediately every time, behaviour is erratic
! button styling wrong
! intro page when event not running seems to be skipped but that isn't react?
NTH: implement loading animation if we do it in polls
! button styling broken