Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18: static/*: update render functions to react18 syntax #1217

Merged
merged 5 commits into from
Sep 26, 2022

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Sep 20, 2022

This PR will make a4 unusable in all other projects!

@github-actions
Copy link

github-actions bot commented Sep 20, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 8.86% 103/1162
🔴 Branches 9.48% 68/717
🔴 Functions 10.08% 37/367
🔴 Lines 15.08% 530/3514

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from ad1a829

@philli-m philli-m changed the title static/*: update render functions to react18 syntax React 18: static/*: update render functions to react18 syntax Sep 20, 2022
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however the comments are still broken, right? How should we do this?

@philli-m
Copy link
Contributor Author

@goapunk I still haven't reviewed your PR yet but can do that next and maybe we merge that one then this, does that make sense?

@goapunk
Copy link
Contributor

goapunk commented Sep 26, 2022

@goapunk I still haven't reviewed your PR yet but can do that next and maybe we merge that one then this, does that make sense?

@phillimorland sounds good to me

@philli-m
Copy link
Contributor Author

@goapunk so shall we merge here?

@goapunk
Copy link
Contributor

goapunk commented Sep 26, 2022

@phillimorland yeah lets give it a try

@goapunk goapunk merged commit 5895ebe into main Sep 26, 2022
@goapunk goapunk deleted the pm-2022-09-mb-react-18 branch September 26, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants