-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 18: static/*: update render functions to react18 syntax #1217
Conversation
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from ad1a829 |
01a4a51
to
ea7c1a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, however the comments are still broken, right? How should we do this?
@goapunk I still haven't reviewed your PR yet but can do that next and maybe we merge that one then this, does that make sense? |
@phillimorland sounds good to me |
@goapunk so shall we merge here? |
@phillimorland yeah lets give it a try |
This PR will make a4 unusable in all other projects!