-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6876] remove django-capture-tag #4805
Conversation
…ag that was used with outdated django-capture-tag
… emails and make command go on if item does not exist
3eee9a5
to
cc781bd
Compare
cc781bd
to
17f3e86
Compare
17f3e86
to
6c434db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks much cleaner! :) and passes everything, only tested 1 email but looks good, i'm not sure on the test code, maybe @Rineee wants to take a quick look?
Yes cool! And coverage up 1.3 % 😁 Do we also want to exclude all other management commands or are they testable? |
@Rineee Yeah, the others are tested or should be... Only for this it didn't make any sense, I thought. |
There are also emails, we don't use?! But this adds all the emails to the management command, so @CarolingerSeilchenspringer can check and we can remove them later. Already took so long as it is...