Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6876] remove django-capture-tag #4805

Merged
merged 5 commits into from
Jan 10, 2023
Merged

Conversation

fuzzylogic2000
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 commented Jan 3, 2023

There are also emails, we don't use?! But this adds all the emails to the management command, so @CarolingerSeilchenspringer can check and we can remove them later. Already took so long as it is...

@fuzzylogic2000 fuzzylogic2000 changed the title WIP: [6876] remove django-captcha-tag WIP: [6876] remove django-captchure-tag Jan 3, 2023
@fuzzylogic2000 fuzzylogic2000 changed the title WIP: [6876] remove django-captchure-tag [6876] remove django-captchure-tag Jan 3, 2023
@fuzzylogic2000 fuzzylogic2000 changed the title [6876] remove django-captchure-tag [6876] remove django-capture-tag Jan 3, 2023
@fuzzylogic2000 fuzzylogic2000 changed the title [6876] remove django-capture-tag WIP: [6876] remove django-capture-tag Jan 4, 2023
… emails and make command go on if item does not exist
@fuzzylogic2000 fuzzylogic2000 force-pushed the kl-2022-12-remove-captcha-tags branch 2 times, most recently from 3eee9a5 to cc781bd Compare January 4, 2023 08:53
@fuzzylogic2000 fuzzylogic2000 changed the title WIP: [6876] remove django-capture-tag [6876] remove django-capture-tag Jan 4, 2023
@fuzzylogic2000 fuzzylogic2000 force-pushed the kl-2022-12-remove-captcha-tags branch from cc781bd to 17f3e86 Compare January 4, 2023 12:42
@fuzzylogic2000 fuzzylogic2000 force-pushed the kl-2022-12-remove-captcha-tags branch from 17f3e86 to 6c434db Compare January 4, 2023 12:44
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks much cleaner! :) and passes everything, only tested 1 email but looks good, i'm not sure on the test code, maybe @Rineee wants to take a quick look?

@Rineee
Copy link
Contributor

Rineee commented Jan 10, 2023

Yes cool! And coverage up 1.3 % 😁 Do we also want to exclude all other management commands or are they testable?

@Rineee Rineee merged commit b68b03e into main Jan 10, 2023
@Rineee Rineee deleted the kl-2022-12-remove-captcha-tags branch January 10, 2023 12:27
@fuzzylogic2000
Copy link
Contributor Author

Yes cool! And coverage up 1.3 % grin Do we also want to exclude all other management commands or are they testable?

@Rineee Yeah, the others are tested or should be... Only for this it didn't make any sense, I thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants