Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6958] apps/budgeting: display "map" as default back-link text, apps/proriza… #4910

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

fuzzylogic2000
Copy link
Contributor

…tions: display "back" as back-link text - fixes #4900

For budgeting always display "map" when not coming from list view

@khamui khamui self-assigned this Feb 7, 2023
Copy link
Contributor

@khamui khamui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm..
just actions is failing, apparently because of a pytest.

question: is there a reason why we do not apply the "list/map/back" as we have it for budgeting?

@fuzzylogic2000
Copy link
Contributor Author

fuzzylogic2000 commented Feb 7, 2023

nice! lgtm.. just actions is failing, apparently because of a pytest.

Oh, right, I did also write tests for the backlink and didn't consider these. 😊 Will fix!

question: is there a reason why we do not apply the "list/map/back" as we have it for budgeting?

The view for the topics doesn't have that, so we cannot use it in the template.

…tions: display "back" as back-link text - fixes #4900
@fuzzylogic2000 fuzzylogic2000 force-pushed the kl-2022-02-back-map-link-wording branch from 2451072 to 1eec241 Compare February 7, 2023 09:26
@fuzzylogic2000 fuzzylogic2000 requested a review from khamui February 7, 2023 09:26
@khamui
Copy link
Contributor

khamui commented Feb 7, 2023

very nice!

@khamui khamui merged commit 6ca3802 into main Feb 7, 2023
@khamui khamui deleted the kl-2022-02-back-map-link-wording branch February 7, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumb in modul "Priorisierung mit Karte" is saying always "list"
2 participants