-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should detect dhclient #225
Comments
At the days of Debian Bug#752111 it was impossible to detect reliable howto get dhclient restarted at all. If some logic could be implemented to detect the various networking configuration frameworks (ifupdown*, NetworkManager, netplan, ...) it might be possible to implement some special handler triggering the dhclient restart somehow. |
why don't we simply add |
We make the call here that dhclient should be *detected*, if not properly restarted. We try to workaround the problem that restarts fail or destroy the network by adding ifupdown to the long list of services that cannot be restarted. We've been running an equivalent configuration in production at the Tor Project over about 100 Debian machines running Debian buster and bullseye for months without negative issues. Closes: liske#225
i have found that dhclient is in the "blacklist" deployed at least by default on Debian. this is because of 54e443b and Debian bug 752111 which said this was causing trouble with network managers like wicd.service.
i would argue, however, that it's not a great idea to just completely silence this warning altogether. i understand the desire to keep network managers from being forcibly restarted, but it would be better to do this at the service level than at the detection level.
because as things stand now, a long-running system daemon (which runs as root too) will not be detected as "needing a restart" by this program, which feels problematic.
we already have
networking
inoverride_rc
. we could addqr(^ifup@.+\.service)
(which i have found on some servers) andwicd
. we'd probably need to add network manager and other things as well.but this exception doesn't seem like the right way to go: it's not like
sudo
orapt
, which are expected to complete and shouldn't matter much if they don't.dhclient
is kind of a big deal...The text was updated successfully, but these errors were encountered: