properly detect dhclient #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We make the call here that dhclient should be *detected*, if not properly restarted. We try to workaround the problem that restarts fail or destroy the network by adding ifupdown to the long list of services that cannot be restarted. We've been running an equivalent configuration in production at the Tor Project over about 100 Debian machines running Debian buster and bullseye for months without negative issues. Closes: liske#225
|
Thanks for the suggestion. I wonder if there might be other setups (i.e. network-manager using dhclient?) which could result in a regression. |
|
well NetworkManager is already listed in the ignore list here, so the point of this PR is really to unify the way we block such cases, to remove the "ifup special case" that seems to be why we don't process dhclient normally. |
|
any reason this is not merged? can i help? |
|
Thanks! Sadly I was very busy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make the call here that dhclient should be detected, if not properly restarted. We try to workaround the problem that restarts fail or destroy the network by adding ifupdown to the long list of services that cannot be restarted.
We've been running an equivalent configuration in production at the Tor Project over about 100 Debian machines running Debian buster and bullseye for months without negative issues.
Closes: #225