-
Notifications
You must be signed in to change notification settings - Fork 206
Miscellaneous repo cleanup #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
798b900
Use playwright's webServer command to start the server
aomarks ba6508e
Update and clean up github actions
aomarks 134ab1e
Minor root package.json metadata
aomarks 9ee2f39
Move tests into new lit-dev-tests package
aomarks 4b48c64
Simplify prettier setup and add check format action
aomarks c46492d
Run prettier
aomarks d801860
Regenerate package locks
aomarks 55f25aa
Fix playwright compile errors
aomarks 4db13e2
Add new packages to vscode workspace
aomarks cfba9a8
Rename lit-dev-tools to lit-dev-tools-cjs to distinguish it from -esm
aomarks 56b898c
Only install manrope if it's missing
aomarks 80607e0
Run unit tests in CI
aomarks 37b258e
Actually do need npm-run-all in root package
aomarks f2e924b
Factor out a base tsconfig
aomarks c331df8
Include tsconfig.base.json in docker
aomarks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,3 +4,4 @@ Dockerfile | |
| npm-debug.log | ||
| **/tsconfig.tsbuildinfo | ||
| /packages/lit-dev-api/lit/ | ||
| /packages/lit-dev-tests/ | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| name: Check format | ||
|
|
||
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| check-format: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 16 | ||
| # Don't cache because we don't bootstrap | ||
|
|
||
| - run: npm ci | ||
| - run: npm run format:check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: Check external links | ||
|
|
||
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| check-links-external: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 16 | ||
| cache: npm | ||
| cache-dependency-path: '**/package-lock.json' | ||
|
|
||
| - run: npm ci | ||
| - run: npm run bootstrap | ||
| - run: npm run build | ||
| - run: npm run test:links:external |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: Check internal links | ||
|
|
||
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| check-links-internal: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 16 | ||
| cache: npm | ||
| cache-dependency-path: '**/package-lock.json' | ||
|
|
||
| - run: npm ci | ||
| - run: npm run bootstrap | ||
| - run: npm run build | ||
| - run: npm run test:links:redirects | ||
| - run: npm run test:links:internal |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: Integration tests | ||
|
|
||
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| integration-tests: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 16 | ||
| cache: npm | ||
| cache-dependency-path: '**/package-lock.json' | ||
|
|
||
| - run: npm ci | ||
| - run: npx playwright install-deps | ||
| - run: npm run bootstrap | ||
| - run: npm run build | ||
|
|
||
| - id: test | ||
| run: npm run test:integration | ||
|
|
||
| - if: ${{ always() && steps.test.outcome == 'failure' }} | ||
| run: npm run test:integration:update-golden-screenshots | ||
|
|
||
| - if: ${{ always() && steps.test.outcome == 'failure' }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: golden-results | ||
| path: tests/**/**.png | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: Unit tests | ||
|
|
||
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| unit-tests: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 16 | ||
| cache: npm | ||
| cache-dependency-path: '**/package-lock.json' | ||
|
|
||
| - run: npm ci | ||
| - run: npm run bootstrap | ||
| - run: npm run build | ||
| - run: npm run test:unit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,39 @@ | ||
| { | ||
| "folders": [ | ||
| { | ||
| "name": "lit-dev-content", | ||
| "path": "packages/lit-dev-content", | ||
| }, | ||
| { | ||
| "name": "lit-dev-tools", | ||
| "path": "packages/lit-dev-tools", | ||
| }, | ||
| { | ||
| "name": "lit-dev-api", | ||
| "path": "packages/lit-dev-api", | ||
| }, | ||
| { | ||
| "name": "lit-dev-server", | ||
| "path": "packages/lit-dev-server", | ||
| }, | ||
| { | ||
| "name": "lit.dev", | ||
| "path": "." | ||
| } | ||
| ], | ||
| "settings": { | ||
| "files.insertFinalNewline": true, | ||
| "files.trimTrailingWhitespace": true, | ||
| }, | ||
| "extensions": { | ||
| "recommendations": [ | ||
| "esbenp.prettier-vscode", | ||
| ] | ||
| } | ||
| "folders": [ | ||
| { | ||
| "name": "lit-dev-content", | ||
| "path": "packages/lit-dev-content" | ||
| }, | ||
| { | ||
| "name": "lit-dev-tools-cjs", | ||
| "path": "packages/lit-dev-tools-cjs" | ||
| }, | ||
| { | ||
| "name": "lit-dev-tools-esm", | ||
| "path": "packages/lit-dev-tools-esm" | ||
| }, | ||
| { | ||
| "name": "lit-dev-tests", | ||
| "path": "packages/lit-dev-tests" | ||
| }, | ||
| { | ||
| "name": "lit-dev-api", | ||
| "path": "packages/lit-dev-api" | ||
| }, | ||
| { | ||
| "name": "lit-dev-server", | ||
| "path": "packages/lit-dev-server" | ||
| }, | ||
| { | ||
| "name": "lit.dev", | ||
| "path": "." | ||
| } | ||
| ], | ||
| "settings": { | ||
| "files.insertFinalNewline": true, | ||
| "files.trimTrailingWhitespace": true | ||
| }, | ||
| "extensions": { | ||
| "recommendations": ["esbenp.prettier-vscode"] | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant!