Always apply participant update, also on existing participants #840
Conversation
🦋 Changeset detectedLatest commit: cf3b8f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| @@ -1447,7 +1444,11 @@ class Room extends (EventEmitter as new () => TypedEmitter<RoomEventCallbacks>) | |||
|
|
|||
| private getOrCreateParticipant(id: string, info?: ParticipantInfo): RemoteParticipant { | |||
| if (this.participants.has(id)) { | |||
| return this.participants.get(id) as RemoteParticipant; | |||
| const participant = this.participants.get(id) as RemoteParticipant; | |||
| if (info) { | |||
There was a problem hiding this comment.
ah interesting.. did we skip the map update if the track came before metadata?
we need a way on the server side to ensure this doesn't happen.
|
do we still want to merge this, even though the issue is probably mitigated with livekit/livekit#1974 ? |
hmm your call on this one.. on one hand, it makes the client more resilient.. on the other, it has a side effect of "hiding" real issues. |
|
My take on this is to keep the behaviour as is in order to surface/notice the issues. But I'm thinking we should then remove the path for tracks to arrive first altogether. It doesn't make a lot of sense to keep a half-broken path around. |
|
Yeah I agree.. I don't think we should have that path anymore. |
|
superseded by #854 |
No description provided.