Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy code paths for tracks arriving before participant info #854

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Aug 29, 2023

livekit server ensures that participant info arrives before the media track. This PR removes the code paths that handle tracks arriving first and logs an error if that's not the case.

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

🦋 Changeset detected

Latest commit: 9a012dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 76.32 KB (+0.05% 🔺)
dist/livekit-client.umd.js 81.77 KB (+0.05% 🔺)

@lukasIO lukasIO requested a review from davidzhao August 29, 2023 11:35
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukasIO lukasIO merged commit 7c29279 into main Aug 29, 2023
@lukasIO lukasIO deleted the lukas/remove-track-first branch August 29, 2023 17:00
@github-actions github-actions bot mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants