-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geth v1.9.0 upgrade #10
Conversation
@kyriediculous please pay attention to changed Livepeer controller address. |
I get those errors too , seems to be related to hardware wallet support which was changed/improved in geth v1.9.0. It shouldn't prevent sealing blocks. I am getting following error in the test-harness using the image created from this , will need to do more testing
Could you elaborate? Ah because I changed the 'from' account in the truffle config in ./build-protocol you mean? Good point. |
Also, it can't initialize new round |
I think I made an additional build with the syncmode flag for which the contracts didn't get migrated. Currently running the test harness locally on v1.8.27 sucessfully, the same version I have installed for myself. Building a new image with 1.9.1 as we speak and will test momentarily with the test-harness |
Yeah, found those too. Will have to dig a little as to why, perhaps some subtle PR that happened. v1.9.0 seems to work except for a failing bond transaction on setup , but a retry of that seems to work. |
3bf8443
to
748ca56
Compare
Settled on geth v1.9.0 for now will check if it's stable in the coming hours. If you want to try it out with the test-harness I uploaded both a v1.8.27 and v1.9.0 image https://cloud.docker.com/repository/docker/vergauwennico/livepeer-testnet/tags |
I've built 1.9.0 locally, but in test harness, it fails to activate orchestrator |
I had some hiccups bonding initially as well but all seems ok now (always failing tx) but on retry of the bonding tx it worked fine. I also experienced the geth container going OOM and getting killed a couple of times but after letting it initialise some rounds and then firing a stream at it it runs just fine. currently running at 100% transcode success rate and 100% ticket redemption rate for over 5 minutes. I am running a local test-harness branch with following branches merged into it though:
re-added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ok, it worked locally for me.
Just don't forget to make PR for test harness with changed Livepeer Controller address in examples
folder
8c646ef
to
21a164a
Compare
This PR upgrades the version of geth being used from 1.7.3 to v1.9.1 so that it includes the constantinople hard fork.
In Dockerfile changed
GETH_MINING_ACCOUNT
env variable to be the correct sealer (0x0161e0...
) as defined in genesis.jsonextradata
field,0x87da6...
is a funded genesis account but not the sealer.Changed indexed
--unlock
to the explicit address of sealer (can unlock all accounts but is this necessary?) (could also use $GETH_MINING_ACCOUNT now)Added
--allow-insecure-unlock
to allow exposing http over RPC with unlocked accountsChanged node to full archive node to prevent state pruning (
--gcmode "archive"
), introduced in geth 1.8.0 this is what lead to loss of state since last 128 blocks are kept in memory only then they are flushed to disk. In addition changedsyncmode
tofull
Added
-rpcvhosts "*"
to allow any DNS rebindingTested by running protocol/pm unit tests against a container running locally
Tested running test-harness
An image can be found at https://cloud.docker.com/u/vergauwennico/repository/docker/vergauwennico/livepeer-testnet
Fixes #9