Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easier on chain default setup #78

Merged
merged 3 commits into from
Jul 31, 2019
Merged

Easier on chain default setup #78

merged 3 commits into from
Jul 31, 2019

Conversation

yondonfu
Copy link
Member

This PR includes a few minor changes that should make it easier for an on-chain default setup to work right after deployment.

  • 8d5fd71: Increase the default ETH funding for accounts and also increase the default deposit and reserve for broadcasters. This should ensure that deposit/reserve funds are not an issue when trying to test an on-chain payment workflow immediately after deployment. Also removed some commented out code that didn't seem needed anymore
  • 440e7af: We need to specify pricePerUnit and pricePerPixel in the standard setup when activating an orchestrator due to cmd, server: O can set/get priceInfo in CLI go-livepeer#993
  • c62b57a: Update some flags and options (seems that using the livepeerBinaryPath option is no longer recommended and building a new image using make localdocker within the go-livepeer directory seems easier?) in the default local config (examples/local.js)

@yondonfu yondonfu requested review from ya7ya and kyriediculous July 26, 2019 20:18
@yondonfu yondonfu mentioned this pull request Jul 30, 2019
Closed
@kyriediculous kyriediculous mentioned this pull request Jul 31, 2019
Merged
kyriediculous
kyriediculous approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@kyriediculous kyriediculous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Might want to wait for Yahya to approve as well although I use this exact same setup locally just fine. 🚀

ya7ya
ya7ya approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@ya7ya ya7ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, Thanks for the smoother setup 👍

@ya7ya ya7ya merged commit 4727420 into master Jul 31, 2019
@yondonfu yondonfu deleted the yf/easier-on-chain-default-setup branch July 31, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyriediculous kyriediculous kyriediculous approved these changes

@ya7ya ya7ya ya7ya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yondonfu @ya7ya @kyriediculous