Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Failing in PHP@7.2.12 #3

Closed
lkaybob opened this issue Nov 13, 2018 · 2 comments
Closed

Build Failing in PHP@7.2.12 #3

lkaybob opened this issue Nov 13, 2018 · 2 comments
Assignees
@lkaybob
Labels
bug Something isn't working

Comments

@lkaybob
Copy link
Owner

lkaybob commented Nov 13, 2018

Build is failing, since PHP@7.2.12 has been released. It seem that timelib has been updated inside the released PHP, and I am working on this issue.
@lkaybob lkaybob added the bug Something isn't working label Nov 13, 2018
@lkaybob lkaybob self-assigned this Nov 13, 2018
@lkaybob
Copy link
Owner Author

lkaybob commented Jul 17, 2019

Starting PHP@7.1, DateTime::__construct fills in microseconds actual value, not 0000.
https://www.php.net/manual/en/datetime.construct.php
briannesbitt/Carbon#1503

As a workaround, setTimeToLive methods now rounds up by seconds.
i.e.) If DateTime::__contruct returns current time as "2019-07-17 06:21:04.693098", current time would be round up as "2019-07-17 06:21:05.000000"

lkaybob added a commit that referenced this issue Jul 17, 2019
@lkaybob
[fix] Issue #3 resolved
ec2dacf 
* Rounded up milliseconds for DateTime::__construct
lkaybob added a commit that referenced this issue Jul 17, 2019
@lkaybob
[fix] Issue #3 implemented
43eb816 
* Fixed broken build < 7.1
lkaybob added a commit that referenced this issue Jul 17, 2019
@lkaybob
[fix] Issue #3 implemented
3fe45ed 
* Fixed broken build on 7.1
lkaybob added a commit that referenced this issue Jul 17, 2019
@lkaybob
Merge pull request #4 from lkaybob/patch/datetime-microsecond
f397061 
[fix] Issue #3 resolved
@lkaybob
Copy link
Owner Author

lkaybob commented Jul 17, 2019

Resolved in #4 .

@lkaybob lkaybob closed this as completed Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lkaybob lkaybob

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lkaybob