Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Issue #3 resolved #4

Merged
merged 3 commits into from
Jul 17, 2019
Merged

[fix] Issue #3 resolved #4

merged 3 commits into from
Jul 17, 2019

Conversation

lkaybob
Copy link
Owner

@lkaybob lkaybob commented Jul 17, 2019

  • Rounded up milliseconds for DateTime::__construct

lkaybob added 2 commits July 17, 2019 15:39
* Rounded up milliseconds for DateTime::__construct
* Fixed broken build < 7.1
@codecov-io

This comment has been minimized.

@lkaybob
Copy link
Owner Author

lkaybob commented Jul 17, 2019

Build fails on 7.1, because implementation on microsecond is different on PHP 7.1
https://travis-ci.org/lkaybob/php-fcm-v1/builds/559820562

Should add PHP_VERSION conditional when rounding up microseconds.

if ($converted->format('u') != 0 && strpos(PHP_VERSION,'7.1') !== 0) {
    $converted = $converted->add(new DateInterval('PT1S'));
}

* Fixed broken build on 7.1
@lkaybob lkaybob merged commit f397061 into master Jul 17, 2019
@lkaybob lkaybob deleted the patch/datetime-microsecond branch July 17, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants